[gapi.client.*] Bulk update Google API namespace#49915
[gapi.client.*] Bulk update Google API namespace#49915typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@Maxim-Mazurok Thank you for submitting this PR! This is a live comment which I will keep updated. 6 packages in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 49915,
"author": "Maxim-Mazurok",
"headCommitAbbrOid": "e7c6d43",
"headCommitOid": "e7c6d43ce2fba5fb3db8bf6a88b502c5589fcca4",
"lastPushDate": "2020-12-04T01:59:20.000Z",
"lastActivityDate": "2020-12-12T02:43:32.000Z",
"maintainerBlessed": false,
"mergeOfferDate": "2020-12-12T02:39:12.000Z",
"mergeRequestDate": "2020-12-12T02:43:32.000Z",
"mergeRequestUser": "Maxim-Mazurok",
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "gapi.client.admin",
"kind": "edit",
"files": [
{
"path": "types/gapi.client.admin/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Maxim-Mazurok",
"namoscato",
"declanvong"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gapi.client.analyticsdata",
"kind": "edit",
"files": [
{
"path": "types/gapi.client.analyticsdata/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Maxim-Mazurok",
"namoscato",
"declanvong"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gapi.client.jobs",
"kind": "edit",
"files": [
{
"path": "types/gapi.client.jobs/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Maxim-Mazurok",
"namoscato",
"declanvong"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gapi.client.reseller",
"kind": "edit",
"files": [
{
"path": "types/gapi.client.reseller/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Maxim-Mazurok",
"namoscato",
"declanvong"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gapi.client.tasks",
"kind": "add",
"files": [
{
"path": "types/gapi.client.tasks/index.d.ts",
"kind": "definition"
},
{
"path": "types/gapi.client.tasks/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/gapi.client.tasks/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/gapi.client.tasks/tslint.json",
"kind": "package-meta",
"suspect": "not the required form"
}
],
"owners": [],
"addedOwners": [
"Maxim-Mazurok",
"namoscato",
"declanvong"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gapi.client.workflowexecutions",
"kind": "add",
"files": [
{
"path": "types/gapi.client.workflowexecutions/index.d.ts",
"kind": "definition"
},
{
"path": "types/gapi.client.workflowexecutions/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/gapi.client.workflowexecutions/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/gapi.client.workflowexecutions/tslint.json",
"kind": "package-meta",
"suspect": "not the required form"
}
],
"owners": [],
"addedOwners": [
"Maxim-Mazurok",
"namoscato",
"declanvong"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2020-12-12T02:38:23.000Z",
"isMaintainer": true
}
],
"ciResult": "pass"
} |
|
🔔 @namoscato @declanvong — please review this PR in the next few days. Be sure to explicitly select |
|
@Maxim-Mazurok The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
20a4267 to
e7c6d43
Compare
|
Hey @Maxim-Mazurok, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. |
|
No tests are necessary since these are only reference packages to actual types. |
|
@Maxim-Mazurok Everything looks good here. Great job! I am ready to merge this PR (at e7c6d43) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present and it shouldn't have any additional or disabling of rules. Just content as{ "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.Related to: Maxim-Mazurok/google-api-typings-generator#408 and microsoft/DefinitelyTyped-tools#183