Skip to content

[@types/underscore] Support readonly tuples in object calls #46650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Aug 11, 2020
Merged

[@types/underscore] Support readonly tuples in object calls #46650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/underscore/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ declare module _ {
// if T is a list, assume that it contains pairs of some type, so any
// if T isn't a list, there's no way that it can provide pairs, so never
type PairValue<T> =
T extends [EnumerableKey, infer TValue] ? TValue
T extends Readonly<[EnumerableKey, infer TValue]> ? TValue
: T extends List<infer TValue> ? TValue
: never;

Expand Down
7 changes: 7 additions & 0 deletions types/underscore/underscore-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,13 @@ _.chain([1, 3, 5])
.intersection([2, 4, 6, 8], [4, 8])
.value();

// "as const" isn't supported until TS3.4; the Readonly assertion below mimics its effect
// $ExpectType Dictionary<number>
_.chain([{ id: 1, name: 'a' }, { id: 2, name: 'b' }])
.map(o => [o.name, o.id] as Readonly<[string, number]>)
.object()
.value();

// common testing types and objects
const context = {};

Expand Down