Skip to content

[@types/parse] TestCollection generic argument fix for changes to Underscore #45748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 1 commit into from
Jun 30, 2020
Merged

[@types/parse] TestCollection generic argument fix for changes to Underscore #45748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/parse/v1/parse-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function test_query() {
const testQuery = Parse.Query.or(query, query);
}

class TestCollection extends Parse.Collection<Object> {
class TestCollection extends Parse.Collection<Parse.Object> {
Copy link
Copy Markdown
Contributor Author

@reubenrybnik reubenrybnik Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at where this is being used a bit more and trying this potential change out, it looks like this generic could also be updated to more specifically reference the Game test class instead if that would be preferable. If I were to do that, I'd probably also update the constructor to take Games as well.


constructor(models?: Parse.Object[]) {

Expand Down