Remove superfluous /// <reference types="node" /> by jablko · Pull Request #44037 · DefinitelyTyped/DefinitelyTyped

jablko · 2020-04-20T00:28:58Z

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with npm test.)
Follow the advice from the readme.
Avoid common mistakes.
Run npm run lint package-name (or tsc if no tslint.json is present).

typescript-bot · 2020-04-20T01:22:33Z

@jablko Thank you for submitting this PR!

🔔 @peterblazejewicz @rogierschouten @remisery @wilfredtan @CjS77 @ebk46 @KonstantinLukaschenko @moeinio @rogatty @AJamesPhillips @jineshshah36 @TimonVS @danielmachado @PaulLockwood @kryops @AndrewGaspar @jvilk @leonard-thieu @LinusU @raybooysen @rsamec @adierkens @dimitardanailov @ulrichheiniger @harm-less @netroy @ffflorian @flying-sheep @avin-kavish @me @nickiannone @johnjbarton @JipSterk @VincentLanglet @kerimdzhanov @nicojs @SomaticIT @cortopy @jkleinsc @shiftkey @malept @tkqubo @harryshipton @bschlenk @Erikma @borislavjivkov @cyrilschumacher @levibostian @Alorel @xbim @Leko @Bartvds @mrmlnc @liorm @GiedriusGrabauskas @amanmahajan7 @jordyvandortmont @silkentrance @tomc974 @k-kagurazaka @tkrotoff @AyaMorisawa @DanielRosenwasser @ntnyq @maxfouquet @Mikhus @TokugawaTakesi @peterjuras @shantmarouti @pine @joeskeen @tscpp @agnislav @yuma84 @Aqours @tkqubo @favna @ChristopherHaws @jedmao @saboya @todd @BlooJeans @pocesar @gaetansenn @jimlloyd @hrl7 @darti @nickp10 @PlayMa256 @stevehipwell @danwbyrne @ChaosinaCan @jgeurts @Perlmint @TotooriaHyperion @bczengel @chrootsu @stepancar @aj-r @e-cloud @thorn0 @jtmthf @DomiR @WilliamChelman @stephenlautier @sampsonjoliver @andipaetzold @JiriBalcar @CodeLenny @ngbrown @theigor @alitaheri @herrmanno @DaIgeb @allienna @schlesingermatthias @InsidersByte @artyomsv @dan-j @minodisk @samwalshnz @reggino @kostap13 @tjuric @nokutu @yoursunny @dex4er @bioball @bacali95 @dagams @khell @zopf @iamolegga @coolreader18 @Rolandisimo @Just1B @nebrius @Aankhen @dthunell @petejohanson @Patrick-Erichsen @trevormcdonald @l-jonas @BendingBender @LucianBuzzo @ajafff @ExE-Boss @hados99 @marcinporebski @bricka @Igorbek @Igmat @lavoaster @Jessidhia @jkillian @eps1lon @flavordaaave @wagerfield @Lazyuki @mgoszcz2 @danilofuchs @forabi @clementallen @kristians-salna @thislooksfun @alan-agius4 @johnnyreilly @vvakame @nchen63 @bitjson @grinich @iclanton @bumbleblym @rynclark @mtraynham @garthk @eoin-obrien @yuanxu - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

shiftkey

Approving on behalf of @types/electron-packager - not sure if there's any specific fedback you're looking for here @jablko...

typescript-bot · 2020-04-20T12:22:54Z

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

elibarzilay · 2020-04-23T19:33:03Z

Is this ready for merging? (It's still marked as "draft")

jablko · 2020-04-24T16:52:26Z

@elibarzilay Thanks for looking at this! It turns out that not all of these are superfluous. I'm working on a revision.

avin-kavish · 2020-04-24T16:58:57Z

Can't we go by a "if it's not broken, don't fix it" approach? Why do we need to remove superfluous types?

andrewbranch · 2020-04-27T18:08:58Z

Leaving it in causes @types/node to be installed as a dependency of these typings for downstream users, which puts unnecessary burden (npm install size and type checker work) on their projects, and can even cause breaks by introducing conflicting globals. IMO this is worth fixing, even if it doesn’t look broken in the vacuum of DefinitelyTyped. Thanks @jablko 💯

peterblazejewicz · 2021-01-07T22:17:52Z

@jablko should we kill or proceed? Maybe we can split this into less problematic, more transparent changes first? (it would take longer though)

typescript-bot · 2024-02-29T23:27:03Z

@jablko Thank you for submitting this PR!

This is a live comment which I will keep updated.

20 packages in this PR

aws-param-store — on npm, on unpkg
boom — on npm, on unpkg
chai-fs — on npm, on unpkg
chai-json-schema — on npm, on unpkg
chai-uuid — on npm, on unpkg
http-aws-es — on npm, on unpkg
mandrill-api — on npm, on unpkg
mobile-messaging-cordova — on npm, on unpkg
rollup-plugin-buble — on npm, on unpkg
rollup-plugin-json — on npm, on unpkg
rollup-plugin-peer-deps-external — on npm, on unpkg
rollup-plugin-progress — on npm, on unpkg
rollup-plugin-size-snapshot — on npm, on unpkg
rollup-plugin-url — on npm, on unpkg
rollup-plugin-visualizer — on npm, on unpkg
rollup__plugin-virtual — on npm, on unpkg
styled-components — on npm, on unpkg
svgr__rollup — on npm, on unpkg
uglify-js — on npm, on unpkg
zui — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 1411 days — it is still unreviewed!

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 44037,
  "author": "jablko",
  "headCommitOid": "175586e8a5d33b7865033af79f7b30dbf56fc37f",
  "mergeBaseOid": "7881f270415e5e53da0885636bc225cce73ada1e",
  "lastPushDate": "2020-04-20T00:28:58.000Z",
  "lastActivityDate": "2024-03-01T00:17:14.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "aws-param-store",
      "kind": "edit",
      "files": [
        {
          "path": "types/aws-param-store/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/aws-param-store/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "jasonthomasgray",
        "nathanoertel"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "boom",
      "kind": "edit",
      "files": [
        {
          "path": "types/boom/v3/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/boom/v3/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "AJamesPhillips",
        "jineshshah36",
        "TimonVS",
        "danielmachado"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "chai-fs",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai-fs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chai-fs/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dimitardanailov"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "chai-json-schema",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai-json-schema/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chai-json-schema/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ulrichheiniger"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "chai-uuid",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai-uuid/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chai-uuid/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "harm-less"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "http-aws-es",
      "kind": "edit",
      "files": [
        {
          "path": "types/http-aws-es/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/http-aws-es/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "marcogrcr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mandrill-api",
      "kind": "edit",
      "files": [
        {
          "path": "types/mandrill-api/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mandrill-api/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "pocesar"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mobile-messaging-cordova",
      "kind": "edit",
      "files": [
        {
          "path": "types/mobile-messaging-cordova/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mobile-messaging-cordova/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "kostap13",
        "tjuric"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup-plugin-buble",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup-plugin-buble/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup-plugin-buble/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Kocal"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup-plugin-json",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup-plugin-json/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup-plugin-json/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "asmockler",
        "hotell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup-plugin-peer-deps-external",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup-plugin-peer-deps-external/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup-plugin-peer-deps-external/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "fobdy",
        "maxbogus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup-plugin-progress",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup-plugin-progress/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup-plugin-progress/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "favna"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup-plugin-size-snapshot",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup-plugin-size-snapshot/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup-plugin-size-snapshot/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "maxbogus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup-plugin-url",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup-plugin-url/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup-plugin-url/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "me"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup-plugin-visualizer",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup-plugin-visualizer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup-plugin-visualizer/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "fobdy",
        "maxbogus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rollup__plugin-virtual",
      "kind": "edit",
      "files": [
        {
          "path": "types/rollup__plugin-virtual/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/rollup__plugin-virtual/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ahum"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "styled-components",
      "kind": "edit",
      "files": [
        {
          "path": "types/styled-components/v3/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/styled-components/v3/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Igorbek",
        "Igmat",
        "Jessidhia",
        "jkillian",
        "eps1lon",
        "wagerfield",
        "Lazyuki",
        "lifeiscontent",
        "acdr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "svgr__rollup",
      "kind": "edit",
      "files": [
        {
          "path": "types/svgr__rollup/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/svgr__rollup/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "fobdy",
        "maxbogus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "uglify-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/uglify-js/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/uglify-js/uglify-js-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alan-agius4",
        "tkrotoff",
        "johnnyreilly",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "zui",
      "kind": "edit",
      "files": [
        {
          "path": "types/zui/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/zui/zui-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "yuanxu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "shiftkey",
      "date": "2020-04-20T12:19:35.000Z",
      "abbrOid": "fcdfe0c"
    }
  ],
  "mainBotCommentID": 1972142920,
  "ciResult": "pass"
}

typescript-bot · 2024-02-29T23:27:06Z

⚠️ There are too many reviewers for this PR change (52). Merging can only be handled by a DT maintainer.

People who would have been pinged

jasonthomasgray nathanoertel Azure AJamesPhillips jineshshah36 TimonVS danielmachado dimitardanailov ulrichheiniger harm-less SpartanLabs ramondeklein stephentuso xbim marcogrcr pocesar mathieudutour kostap13 tjuric rogierschouten dex4er bioball Kocal asmockler hotell kocal fobdy maxbogus favna me ahum everettcaleb azatoth geoffreak Igorbek Igmat Jessidhia jkillian eps1lon wagerfield Lazyuki lifeiscontent acdr alan-agius4 tkrotoff johnnyreilly peterblazejewicz e-cloud domdomegg cjbarth felix-hoc yuanxu

typescript-bot · 2024-02-29T23:27:07Z

@shiftkey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2024-02-29T23:27:07Z

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @jablko.

(Ping @jasonthomasgray, @nathanoertel, @AJamesPhillips, @jineshshah36, @TimonVS, @danielmachado, @dimitardanailov, @ulrichheiniger, @harm-less, @marcogrcr, @pocesar, @kostap13, @tjuric, @Kocal, @asmockler, @Hotell, @fobdy, @maxbogus, @favna, @me, @ahum, @Igorbek, @Igmat, @Jessidhia, @jkillian, @eps1lon, @wagerfield, @Lazyuki, @lifeiscontent, @ACDR, @alan-agius4, @tkrotoff, @johnnyreilly, @peterblazejewicz, @yuanxu.)

shiftkey · 2024-02-29T23:58:06Z

@shiftkey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

The package I was reviewing is no longer part of this PR, so I'm going to ignore these latest commits

jakebailey · 2024-03-01T00:15:33Z

Yep, sorry about that; the woes of resurrecting an ancient PR.

jakebailey · 2024-03-01T00:17:14Z

A lot of these are cases where they really do pull in node types, but now do it indirectly afterwards. I will probably modify this PR to remove those cases as I think the indirect loading is probably not the best thing to have.

typescript-bot · 2024-03-01T00:24:33Z

🔔 @jasonthomasgray @nathanoertel @AJamesPhillips @jineshshah36 @TimonVS @danielmachado @dimitardanailov @ulrichheiniger @harm-less @marcogrcr @pocesar @kostap13 @tjuric @Kocal @asmockler @Hotell @fobdy @maxbogus @favna @me @ahum @Igorbek @Igmat @Jessidhia @jkillian @eps1lon @wagerfield @Lazyuki @lifeiscontent @ACDR @alan-agius4 @tkrotoff @johnnyreilly @peterblazejewicz @yuanxu — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

jablko mentioned this pull request Apr 20, 2020

[any-db-transaction] Remove superfluous /// <reference types="node" /> #44038

Closed

typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Apr 20, 2020

typescript-bot added the Awaiting reviewer feedback label Apr 20, 2020

shiftkey approved these changes Apr 20, 2020

View reviewed changes

typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Apr 20, 2020

jablko force-pushed the patch-5 branch 3 times, most recently from ff52fb9 to e04896a Compare April 28, 2020 03:05

jablko force-pushed the patch-5 branch 3 times, most recently from c9b5479 to 9ca1c38 Compare August 13, 2020 00:01

Remove superfluous /// <reference types="node" />

dae0caf

jablko force-pushed the patch-5 branch from 9ca1c38 to dae0caf Compare August 13, 2020 15:18

elibarzilay removed the Merge:Express label Nov 19, 2020

jakebailey added 6 commits February 29, 2024 14:04

Merge branch 'master' into pr-44037

f21354d

revert

d8a170a

clean up package.jsons

2f6d59a

missing

0f6fa75

Revert

3405ec4

revert

7cbaee3

jakebailey marked this pull request as ready for review February 29, 2024 23:25

jakebailey requested review from Igorbek, johnnyreilly and peterblazejewicz as code owners February 29, 2024 23:25

jakebailey added 2 commits February 29, 2024 16:17

Merge branch 'master' into pr-44037

d96f002

Drop ones that are obviously using node modules

175586e

typescript-bot removed the Too Many Owners label Mar 1, 2024

jakebailey merged commit 62f8b0f into DefinitelyTyped:master Mar 1, 2024

Conversation

jablko commented Apr 20, 2020

Uh oh!

typescript-bot commented Apr 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shiftkey left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Apr 20, 2020

Uh oh!

elibarzilay commented Apr 23, 2020

Uh oh!

jablko commented Apr 24, 2020

Uh oh!

avin-kavish commented Apr 24, 2020

Uh oh!

andrewbranch commented Apr 27, 2020

Uh oh!

peterblazejewicz commented Jan 7, 2021

Uh oh!

typescript-bot commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

20 packages in this PR

Code Reviews

Status

Inactive

Uh oh!

typescript-bot commented Feb 29, 2024

Uh oh!

typescript-bot commented Feb 29, 2024

Uh oh!

typescript-bot commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shiftkey commented Feb 29, 2024

Uh oh!

jakebailey commented Mar 1, 2024

Uh oh!

jakebailey commented Mar 1, 2024

Uh oh!

typescript-bot commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

typescript-bot commented Apr 20, 2020 •

edited

Loading

typescript-bot commented Feb 29, 2024 •

edited

Loading

typescript-bot commented Feb 29, 2024 •

edited

Loading