feat(html2canvas): delete @types/html2canvas#41418
feat(html2canvas): delete @types/html2canvas#41418peterblazejewicz wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@peterblazejewicz Thank you for submitting this PR! 🔔 @rwhepburn @tan9 @sschocke @Ristaaf - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@peterblazejewicz The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
As of version 1.0.0-rc2 `html2cavans` now ships with its own type definitions: https://github.com/niklasvh/html2canvas/releases/tag/v1.0.0-rc.2 Thanks!
86fa926 to
1e1321b
Compare
|
@peterblazejewicz The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
It seems the |
|
@peterblazejewicz I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
@peterblazejewicz To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
Starging from version 1.0.0-rc2
html2cavansnow ships with its own typedefinitions:
https://github.com/niklasvh/html2canvas/releases/tag/v1.0.0-rc.2
Recent ones:
https://unpkg.com/html2canvas@1.0.0-rc.5/dist/types/index.d.ts
Thanks!
notNeededPackages.json./cc @rwhepburn @tan9 @sschocke @Ristaaf