-
Notifications
You must be signed in to change notification settings - Fork 30.6k
Trim tsconfig files; move untested files to OTHER_FILES.txt #40676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
cf905d3
Initial cut
sandersn e13e28c
Merge branch 'master' into move-untested-sourcefiles-to-OTHER_FILES
sandersn 4a34231
fix aos global reference
sandersn 67ff549
fix clearbladejs global references
sandersn d3cf16a
fix cldr.js augmentations
sandersn 4b1d9a1
fix codemirror compile errors (maybe)
sandersn c051a12
fixup skipped files after merge
sandersn 0a1dc34
fix dwt/v13
sandersn 2d9dbd2
add missing references to adone
sandersn bff0474
fix meteor (manually)
sandersn 9003953
fix rangy
sandersn bd0bfc7
add missing file reference to react-blessed
sandersn f05cf5b
fix react-dom?
sandersn ae566c1
bump codemirror to 3.2
sandersn 37f0537
bump dwt to 3.2
sandersn 25b9618
Add/remove OTHER_FILES.txt as needed.
sandersn 5a38d8d
bump react-codemirror to 3.2
sandersn 1bff7aa
add references to slickgrid tests
sandersn 1bc3695
add reference to strophe.js tests
sandersn 638a235
add reference to strophe+fix types
sandersn 01905cf
add reference to waypoints test
sandersn 7cd1791
Bump others to 3.9
sandersn a699dcb
remove incorrectly added file
sandersn f742a9c
Use more explicit types reference paths
sandersn 4762361
Merge branch 'master' into move-untested-sourcefiles-to-OTHER_FILES
sandersn 742c8d9
bump strophejs-plugin-roster TS version
sandersn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ | |
| }, | ||
| "files": [ | ||
| "index.d.ts", | ||
| "lite/index.d.ts", | ||
| "algoliasearch-tests.ts" | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| AmStockChart.d.ts | ||
| AreasSettings.d.ts | ||
| CategoryAxesSettings.d.ts | ||
| ChartCursorSettings.d.ts | ||
| ChartScrollbarSettings.d.ts | ||
| DataSet.d.ts | ||
| DataSetSelector.d.ts | ||
| ImagesSettings.d.ts | ||
| LegendSettings.d.ts | ||
| PanelSettings.d.ts | ||
| PeriodSelector.d.ts | ||
| StockEvent.d.ts | ||
| StockGraph.d.ts | ||
| StockLegend.d.ts | ||
| StockPanel.d.ts | ||
| ValueAxesSettings.d.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ | |
| }, | ||
| "files": [ | ||
| "index.d.ts", | ||
| "callback_api.d.ts", | ||
| "amqplib-tests.ts" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| { | ||
| "files": [ | ||
| "index.d.ts", | ||
| "mocks.d.ts", | ||
| "angular-mocks-tests.ts" | ||
| ], | ||
| "compilerOptions": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| error/index.d.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,23 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "module": "commonjs", | ||
| "lib": ["es2015"], | ||
| "noImplicitAny": true, | ||
| "noImplicitThis": true, | ||
| "strictFunctionTypes": true, | ||
| "strictNullChecks": true, | ||
| "baseUrl": "../", | ||
| "typeRoots": ["../"], | ||
| "types": [], | ||
| "noEmit": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "files": [ | ||
| "implementation.d.ts", | ||
| "index.d.ts", | ||
| "polyfill.d.ts", | ||
| "shim.d.ts", | ||
| "array.from-tests.ts" | ||
| ] | ||
| } | ||
| "compilerOptions": { | ||
| "module": "commonjs", | ||
| "lib": [ | ||
| "es2015" | ||
| ], | ||
| "noImplicitAny": true, | ||
| "noImplicitThis": true, | ||
| "strictFunctionTypes": true, | ||
| "strictNullChecks": true, | ||
| "baseUrl": "../", | ||
| "typeRoots": [ | ||
| "../" | ||
| ], | ||
| "types": [], | ||
| "noEmit": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "files": [ | ||
| "index.d.ts", | ||
| "array.from-tests.ts" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "module": "commonjs", | ||
| "lib": ["es6"], | ||
| "lib": [ | ||
| "es6" | ||
| ], | ||
| "noImplicitAny": true, | ||
| "noImplicitThis": true, | ||
| "strictFunctionTypes": true, | ||
| "strictNullChecks": true, | ||
| "baseUrl": "../", | ||
| "typeRoots": ["../"], | ||
| "typeRoots": [ | ||
| "../" | ||
| ], | ||
| "types": [], | ||
| "noEmit": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "files": [ | ||
| "array.prototype.flat-tests.ts", | ||
| "auto.d.ts", | ||
| "implementation.d.ts", | ||
| "index.d.ts", | ||
| "polyfill.d.ts", | ||
| "shim.d.ts" | ||
| "index.d.ts" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ | |
| }, | ||
| "files": [ | ||
| "asap-tests.ts", | ||
| "index.d.ts", | ||
| "raw.d.ts" | ||
| "index.d.ts" | ||
| ] | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean if a user imports
algoliasearch/litenow? I think I'm a little lost :)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing changes for users — notice that algoliasearch wasn't one of the packages that published a new version.
In fact, nothing really changes for algoliasearch since its tests already import and test algoliasearch/lite.
lite/index.d.tsjust isn't in tsconfig.json anymore, which means that it won't be published unless you test it — what algoliasearch does — or add it to OTHER_FILES.txt to indicate that it should be published untested. Only about 100 packages do the latter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that makes lots of sense, and makes it simpler to add "common" files which aren't exports. Thanks!