Skip to content

node-fetch: allow agent to accept a function returning Agent #36057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuckton merged 4 commits into from
Jun 12, 2019
Merged

node-fetch: allow agent to accept a function returning Agent #36057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8574969
Allow Agent to accept a function
southpolesteve Jun 8, 2019
5488426
Fix types
southpolesteve Jun 9, 2019
fa6cd01
string -> URL
southpolesteve Jun 9, 2019
23ca69e
Update index.d.ts
southpolesteve Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions types/node-fetch/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
// Andrew Leedham <https://github.com/AndrewLeedham>
// Jason Li <https://github.com/JasonLi914>
// Brandon Wilson <https://github.com/wilsonianb>
// Steve Faulkner <https://github.com/southpolesteve>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped

/// <reference types="node" />

import { Agent } from "http";
import { URLSearchParams } from "url";
import { URLSearchParams, URL } from "url";
import { AbortSignal } from "./externals";

export class Request extends Body {
Expand All @@ -26,7 +27,7 @@ export class Request extends Body {
url: string;

// node-fetch extensions to the whatwg/fetch spec
agent?: Agent;
agent?: Agent | ((parsedUrl: URL) => Agent);
compress: boolean;
counter: number;
follow: number;
Expand Down
3 changes: 2 additions & 1 deletion types/node-fetch/node-fetch-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import fetch, {
Response,
FetchError
} from "node-fetch";
import { URL } from "url";
import { Agent } from "http";

function test_fetchUrlWithOptions() {
Expand Down Expand Up @@ -73,7 +74,7 @@ function test_fetchUrlWithRequestObject() {
);
const timeout: number = request.timeout;
const size: number = request.size;
const agent: Agent | undefined = request.agent;
const agent: Agent | ((parsedUrl: URL) => Agent) | undefined = request.agent;
const protocol: string = request.protocol;

handlePromise(fetch(request));
Expand Down