Skip to content

Conversation

@do7be
Copy link
Contributor

@do7be do7be commented Feb 27, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 27, 2019

@do7be Thank you for submitting this PR!

🔔 @matracey - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

*/
y?: number;
}
interface globalOpts {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GlobalOptions?

function create(
canvas: HTMLCanvasElement,
options?: globalOpts
): (options?: Options) => Promise<null> | null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's actually a Promise<void> (when it's not null), but that's also a problem with the top level function confetti

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Feb 27, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@Jessidhia Jessidhia merged commit 23c22a5 into DefinitelyTyped:master Feb 27, 2019
@typescript-bot
Copy link
Contributor

I just published @types/canvas-confetti@0.1.0 to npm.

@do7be do7be deleted the feature/add-create-types-for-canvas-confetti branch February 27, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants