-
Notifications
You must be signed in to change notification settings - Fork 30.5k
Add 'create' types for canvas-confetti #33431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'create' types for canvas-confetti #33431
Conversation
|
@do7be Thank you for submitting this PR! 🔔 @matracey - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
types/canvas-confetti/index.d.ts
Outdated
| */ | ||
| y?: number; | ||
| } | ||
| interface globalOpts { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GlobalOptions?
| function create( | ||
| canvas: HTMLCanvasElement, | ||
| options?: globalOpts | ||
| ): (options?: Options) => Promise<null> | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's actually a Promise<void> (when it's not null), but that's also a problem with the top level function confetti
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
I just published |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.