[@types/ember] Add url property to deprecation options#32538
[@types/ember] Add url property to deprecation options#32538simonihmig wants to merge 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@simonihmig Thank you for submitting this PR! 🔔 @jedmao @bttf @dwickern @chriskrycho @theroncross @mfeckie @alexlafroscia @mike-north @BryanCrotaz - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
I think the Can you update it too? |
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
Yes, will do so. Don't merge yet! |
|
Updated |
| id: 'no-longer-advised', | ||
| until: 'v4.0' | ||
| until: 'v4.0', | ||
| url: 'https://emberjs.com' |
There was a problem hiding this comment.
I'm not sure if it's better, but if you split this call into two where one contains the url and the other doesn't, it keeps the old test while testing the new (optional) behavior.
There was a problem hiding this comment.
Sure, updated it!
|
Let me know when you feel confident for merging and I can take care of that. |
0926c56 to
3ceffeb
Compare
From my point of view, this should be ready. |
|
@simonihmig The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
The failing test seems unrelated. Also fails in master, as well as in #32770 |
|
@simonihmig I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
3ceffeb to
604abe3
Compare
|
Rebased this again, in the hope that this fixes the (unrelated) test failures. |
|
Tests are currently failing on master w/ TS 3.4 nightlies due to microsoft/TypeScript#29765 (fix PR: microsoft/TypeScript#29787) |
|
@simonihmig The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
looks like the TS upstream fix is in. Once a new |
|
@simonihmig To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.