Skip to content

add typings for @google-cloud/tasks#31145

Closed
ifiokjr wants to merge 2 commits intoDefinitelyTyped:masterfrom
ifiokjr:google-cloud__tasks
Closed

add typings for @google-cloud/tasks#31145
ifiokjr wants to merge 2 commits intoDefinitelyTyped:masterfrom
ifiokjr:google-cloud__tasks

Conversation

@ifiokjr
Copy link
Contributor

@ifiokjr ifiokjr commented Dec 7, 2018 •
edited
Loading

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration

Caveats

The build will currently fail as it's referencing types from an external package. I've created a PR microsoft/types-publisher#542 to add google-gax to the types-publisher which should resolve this build issue.

This PR deals with the types for the default export only v2beta3. I have left out the v2beta2 intentionally as I'm not planning on using the older version. Feel free to create a PR in the future to resolve this.

@ifiokjr ifiokjr mentioned this pull request Dec 7, 2018
Closed
@ifiokjr ifiokjr force-pushed the google-cloud__tasks branch 2 times, most recently from f6bf2a8 to 4b6c07a Compare December 7, 2018 00:47
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 7, 2018 •
edited
Loading

@ifiokjr Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. The Travis CI build failed labels Dec 7, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 7, 2018

@ifiokjr The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 7, 2018 •
edited
Loading

@ifiokjr The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ifiokjr ifiokjr mentioned this pull request Dec 7, 2018
Merged
@ifiokjr
Copy link
Contributor Author

ifiokjr commented Dec 11, 2018

Just so you know, I'm still waiting on the google-gax dependency to be added to the whitelist in microsoft/types-publisher#542.

It seems they've got a bit of a backlog on their hands.

@ifiokjr ifiokjr force-pushed the google-cloud__tasks branch from 2df329b to 3bb8daf Compare December 12, 2018 16:17
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 12, 2018 •
edited
Loading

@ifiokjr The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ifiokjr ifiokjr force-pushed the google-cloud__tasks branch 2 times, most recently from fe20b61 to 271e0fa Compare December 13, 2018 08:03
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 13, 2018 •
edited
Loading

@ifiokjr The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ifiokjr ifiokjr force-pushed the google-cloud__tasks branch from 271e0fa to 16b62b3 Compare December 14, 2018 07:02
@ifiokjr
fix: strictFunctionTypes fails on ci
20bb3ae 
On CI this fails if not present, but locally it fails when present.
@ifiokjr ifiokjr force-pushed the google-cloud__tasks branch from 16b62b3 to 20bb3ae Compare December 14, 2018 07:06
@ifiokjr
Copy link
Contributor Author

ifiokjr commented Dec 14, 2018 •
edited
Loading

I'm not sure how to get this build to pass. At the moment it fails because of a downstream dependency library. The travis build has more information.

Error in google-cloud__tasks
Error: Errors in typescript@3.0 for external dependencies:
node_modules/google-auth-library/build/src/auth/oauth2client.d.ts(291,55): error TS1039: Initializers are not allowed in ambient contexts.

The error is caused by this line in the non-compiled code.

protected static readonly GOOGLE_TOKEN_INFO_URL = "https://oauth2.googleapis.com/tokeninfo";
  • skipLibCheck is not a supported option so I can't just ignore the library checks.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 14, 2018 •
edited
Loading

@ifiokjr The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 20, 2018

@ifiokjr I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Dec 21, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 21, 2018

@ifiokjr To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

@ifiokjr ifiokjr mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Abandoned This PR had no activity for a long time, and is considered abandoned New Definition This PR creates a new definition package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ifiokjr @typescript-bot