[react-native] Add missing style props to View by brunolemos · Pull Request #25735 · DefinitelyTyped/DefinitelyTyped

brunolemos · 2018-05-12T19:47:16Z

Continuation of #25083

React Native actually accepts the whole ViewStyle as props, not only the FlexStyle.

Before this PR, it wouldn't allow me to do <View backgroundColor="#00FF00" />, after it will.

PS: I noticed an existing type error but I don't know how to fix it: overflow can have the scroll value, but it is currently not autocompleting that. If we add this the ImageStyle gives an error when trying to override it. (fixed)

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with npm test.)
Follow the advice from the readme.
Avoid common mistakes.
Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/facebook/react-native/blob/master/Libraries/Components/View/ViewStylePropTypes.js
Increase the version number in the header if appropriate.
If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

https://github.com/facebook/react-native/blob/master/Libraries/Components/View/ViewStylePropTypes.js

typescript-bot · 2018-05-12T20:22:28Z

@brunolemos Thank you for submitting this PR!

🔔 @alloy @huhuanming @iRoachie @timwangdev @kamal @nelyousfi @alexdunne @swissmanu @bm-software @jnbt @j-fro @gazaret - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

typescript-bot · 2018-05-13T13:22:42Z

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

alloy · 2018-05-14T13:29:30Z

types/react-native-snap-carousel/index.d.ts

     * Optional styles for Scrollview's global wrapper
     */
-    containerCustomStyle?: StyleProp<ScrollViewStyle>;
+    containerCustomStyle?: StyleProp<ViewStyle>;


I’m a little confused, isn’t this limiting the available styles to a superset of the available scrollview styles?

It's supposed to be a ViewStyle according to the source https://github.com/archriss/react-native-snap-carousel/blob/59b1d90f7e5ad23d4c4ced241ec15379e5d2fb6d/src/carousel/Carousel.js#L46

Ah gotcha 👍

alloy

I’d really appreciate some changes to the tests that reflect the important changes in here to ensure we can fully understand them now and in the future.

typescript-bot · 2018-05-14T14:30:10Z

@brunolemos One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

alloy · 2018-05-15T13:21:39Z

@iRoachie Just from reading the changes I have a hard time feeling assured that I understand how all changes will affect existing code bases, but if you feel that you do then let me know and I’ll merge as-is.

brunolemos · 2018-05-15T16:34:25Z

I can add a couple tests later today

typescript-bot · 2018-05-16T07:24:16Z

🔔 @alloy - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

alloy · 2018-05-16T13:38:35Z

Thanks! 👍

hpmax00 · 2018-07-26T07:52:32Z

#27595

brunolemos added 2 commits May 12, 2018 16:45

[react-native] Add missing fields on ViewStyle

96f741e

[react-native] Make ViewProps extends ViewStyle

8cc6c8d

https://github.com/facebook/react-native/blob/master/Libraries/Components/View/ViewStylePropTypes.js

brunolemos requested a review from alloy as a code owner May 12, 2018 19:47

[react-native] Remove references of ScrollViewStyle

27646c6

typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels May 12, 2018

[react-native] Make View overflow support scroll value

3d7e710

iRoachie approved these changes May 13, 2018

View reviewed changes

typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels May 13, 2018

alloy reviewed May 14, 2018

View reviewed changes

alloy requested changes May 14, 2018

View reviewed changes

typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels May 14, 2018

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 14, 2018

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 15, 2018

brunolemos added 3 commits May 16, 2018 01:30

[react-native] Image props should extend ImageStyle intead of ViewStyle

d12e4ba

[react-native] Add tests for ImageStyle and ViewStyle as props

ddac6e2

[react-native] [Image] Disable broken props: width, height and tintColor

cf5dd19

brunolemos force-pushed the view-style-props branch from 10c5f31 to cf5dd19 Compare May 16, 2018 07:03

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 16, 2018

alloy approved these changes May 16, 2018

View reviewed changes

alloy merged commit 23f5219 into DefinitelyTyped:master May 16, 2018

terrierscript mentioned this pull request Jul 21, 2018

ScrollViewStyle -> ViewStyle saleel/react-native-super-grid#55

Merged

brunolemos mentioned this pull request Aug 18, 2018

[react-native] Disable styles as props #28217

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[react-native] Add missing style props to View#25735

[react-native] Add missing style props to View#25735
alloy merged 7 commits intoDefinitelyTyped:masterfrom
brunolemos:view-style-props

brunolemos commented May 12, 2018 •

edited

Loading

Uh oh!

typescript-bot commented May 12, 2018 •

edited

Loading

Uh oh!

typescript-bot commented May 13, 2018

Uh oh!

alloy May 14, 2018

Uh oh!

iRoachie May 14, 2018

Uh oh!

alloy May 14, 2018

Uh oh!

alloy left a comment

Uh oh!

typescript-bot commented May 14, 2018

Uh oh!

alloy commented May 15, 2018

Uh oh!

brunolemos commented May 15, 2018

Uh oh!

typescript-bot commented May 16, 2018

Uh oh!

alloy commented May 16, 2018

Uh oh!

hpmax00 commented Jul 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

brunolemos commented May 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 13, 2018

Uh oh!

alloy May 14, 2018

Choose a reason for hiding this comment

Uh oh!

iRoachie May 14, 2018

Choose a reason for hiding this comment

Uh oh!

alloy May 14, 2018

Choose a reason for hiding this comment

Uh oh!

alloy left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented May 14, 2018

Uh oh!

alloy commented May 15, 2018

Uh oh!

brunolemos commented May 15, 2018

Uh oh!

typescript-bot commented May 16, 2018

Uh oh!

alloy commented May 16, 2018

Uh oh!

hpmax00 commented Jul 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brunolemos commented May 12, 2018 •

edited

Loading

typescript-bot commented May 12, 2018 •

edited

Loading