Skip to content

[react-native-linear-gradient] Remove Typings#25147

Merged
weswigham merged 1 commit intoDefinitelyTyped:masterfrom
brunolemos:patch-13
Apr 25, 2018
Merged

[react-native-linear-gradient] Remove Typings#25147
weswigham merged 1 commit intoDefinitelyTyped:masterfrom
brunolemos:patch-13

Conversation

@brunolemos
Copy link
Copy Markdown
Contributor

@brunolemos brunolemos commented Apr 19, 2018

The project has a index.d.ts file since v2.4.0.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

The project has a `index.d.ts` file since v2.4.0.
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 19, 2018

@brunolemos Thank you for submitting this PR!

🔔 @j-fro - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Apr 24, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@weswigham weswigham merged commit e5c82b2 into DefinitelyTyped:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants