Skip to content

Fix missing splat in react-intl types #25046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCavanaugh merged 1 commit into from
Apr 17, 2018
Merged

Fix missing splat in react-intl types #25046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/react-intl/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ declare namespace ReactIntl {
interface Props extends MessageDescriptor {
values?: {[key: string]: MessageValue | JSX.Element};
tagName?: string;
children?: (formattedMessage: string[]) => React.ReactNode;
children?: (...formattedMessage: string[]) => React.ReactNode;
}
}
class FormattedMessage extends React.Component<FormattedMessage.Props> { }
Expand Down
14 changes: 14 additions & 0 deletions types/react-intl/react-intl-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,20 @@ class SomeComponent extends React.Component<SomeComponentProps & InjectedIntlPro
{(text) => <div className="messageDiv">{text}</div>}
</FormattedMessage>

<FormattedMessage
id="test"
description="Test"
>
{(text) => <input placeholder={text} />}
</FormattedMessage>

<FormattedMessage
id="test"
description="Test"
>
{(...text) => <ul>{text.map(t => <li>{t}</li>)}</ul>}
</FormattedMessage>

<FormattedHTMLMessage
id="test"
description="Test"
Expand Down