Skip to content

[Ramda]: fixed pick and omit type signatures to reflect projections #24936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCavanaugh merged 7 commits into from
Apr 17, 2018
Merged

[Ramda]: fixed pick and omit type signatures to reflect projections #24936

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bc35a9b
fixed pick and omit type signatures to be more helpful
ProofOfKeags Apr 12, 2018
e6776ca
changed pick to try and pass tests, tsnext still complaining
ProofOfKeags Apr 12, 2018
d689e8d
added CaptJakk to contributors
ProofOfKeags Apr 12, 2018
d3d25b0
changed keyof index signatures to just strings
ProofOfKeags Apr 16, 2018
de8e110
simplified Omit type signature
ProofOfKeags Apr 17, 2018
9a733ce
Merge branch 'master' into feature/pick-omit-type-correctness
ProofOfKeags Apr 17, 2018
af1f957
Merge branch 'feature/pick-omit-type-correctness' of github.com:CaptJ…
ProofOfKeags Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions types/ramda/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
declare let R: R.Static;

declare namespace R {
type Diff<T extends string, U extends string> = ({[P in T]: P } & {[P in U]: never } & { [x: string]: never })[T];
type Omit<T, K extends string> = Pick<T, Diff<keyof T, K>>;

type Ord = number | string | boolean;

type Path = ReadonlyArray<(number | string)>;
Expand Down Expand Up @@ -1174,8 +1177,8 @@ declare namespace R {
/**
* Returns a partial copy of an object omitting the keys specified.
*/
omit<T>(names: ReadonlyArray<string>, obj: T): T;
omit(names: ReadonlyArray<string>): <T>(obj: T) => T;
omit<T, K extends string>(names: ReadonlyArray<K>, obj: T): Omit<T, K>;
omit<K extends string>(names: ReadonlyArray<K>): <T>(obj: T) => Omit<T, K>;

/**
* Accepts a function fn and returns a function that guards invocation of fn such that fn can only ever be
Expand Down Expand Up @@ -1285,8 +1288,8 @@ declare namespace R {
* Returns a partial copy of an object containing only the keys specified. If the key does not exist, the
* property is ignored.
*/
pick<T, K extends keyof T>(names: ReadonlyArray<K | string>, obj: T): Pick<T, K>;
pick(names: ReadonlyArray<string>): <T, U>(obj: T) => U;
pick<T, K extends string>(names: ReadonlyArray<K>, obj: T): Pick<T, Diff<keyof T, keyof Omit<T, K>>>;
pick<K extends string>(names: ReadonlyArray<K>): <T>(obj: T) => Pick<T, Diff<keyof T, keyof Omit<T, K>>>;

/**
* Similar to `pick` except that this one includes a `key: undefined` pair for properties that don't exist.
Expand Down