Skip to content

Update type react-toastr: Allow JSX to be used for title and message content. #24910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCavanaugh merged 4 commits into from
Apr 16, 2018
Merged

Update type react-toastr: Allow JSX to be used for title and message content. #24910

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b169898
Updated the typings to allow JSX elements in addition to strings for …
Apr 11, 2018
2f5e2ff
Update version number of react-toastr type definition.
Apr 11, 2018
7bfbf91
Revert version number to match toastr's version number
Apr 13, 2018
259fc54
ReactNode includes string.
Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions types/react-toastr/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Type definitions for react-toastr 3.0
// Project: https://github.com/tomchentw/react-toastr
// Definitions by: Josh Holmer <https://github.com/shssoichiro>
// Definitions by: Josh Holmer <https://github.com/shssoichiro>, Dan Regazzi <https://github.com/DanRegazzi>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.6

Expand All @@ -10,10 +10,10 @@ export class ToastContainer extends Component<{
toastMessageFactory: any;
className?: string;
}> {
error: (message: string, title: string, optionsOverride?: {}) => void;
info: (message: string, title: string, optionsOverride?: {}) => void;
success: (message: string, title: string, optionsOverride?: {}) => void;
warning: (message: string, title: string, optionsOverride?: {}) => void;
error: (message: React.ReactNode, title: React.ReactNode, optionsOverride?: {}) => void;
info: (message: React.ReactNode, title: React.ReactNode, optionsOverride?: {}) => void;
success: (message: React.ReactNode, title: React.ReactNode, optionsOverride?: {}) => void;
warning: (message: React.ReactNode, title: React.ReactNode, optionsOverride?: {}) => void;
clear: () => void;
}
export const ToastMessageAnimated: keyof ReactHTML;
Expand Down