Skip to content

@types/redux-form Removed Partial from onSubmit values #24816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 1 commit into from
Apr 14, 2018
Merged

@types/redux-form Removed Partial from onSubmit values #24816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/redux-form/lib/reduxForm.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
} from "../index";

export type FormSubmitHandler<FormData = {}, P = {}> =
(values: Partial<FormData>, dispatch: Dispatch<any>, props: P) => void | FormErrors<FormData> | Promise<any>;
(values: FormData, dispatch: Dispatch<any>, props: P) => void | FormErrors<FormData> | Promise<any>;
Copy link
Copy Markdown
Member

@Jessidhia Jessidhia Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was rather confused when I looked at this because FormData is an actual DOM API constructor/instance and it makes no sense to have a Partial<FormData>. Naming it TFormData might make it less confusing, but that's not the point of the PR 🤷‍♀️


export interface SubmitHandler<FormData = {}, P = {}> {
(
Expand Down