Skip to content

[stripe] Fix typo in IProductCreationOptions. #24796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 2 commits into from
Apr 9, 2018
+5 −3
Merged

[stripe] Fix typo in IProductCreationOptions. #24796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b349bbf
[stripe] Fix typo in `IProductCreationOptions`.
psigen Apr 7, 2018
0833fb2
Added `attributes` to tests for product creation.
psigen Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/stripe/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3029,7 +3029,7 @@ declare namespace Stripe {
* A list of up to 5 alphanumeric attributes that each SKU can provide values for (e.g. ["color", "size"]).
* Applicable to both service and good types.
*/
attribute?: Array<string>;
attributes?: Array<string>;

/**
* A short one-line description of the product, meant to be displayable to the customer. May only be set if type=good.
Expand Down
6 changes: 4 additions & 2 deletions types/stripe/stripe-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,13 +796,15 @@ stripe.accounts.createExternalAccount("", { external_account: "tok_15V2YhEe31JkL

stripe.products.create({
name: "My amazing product",
type: "service"
type: "service",
attributes: ["color"]
}, function (err, coupon) {
// asynchronously called
});
stripe.products.create({
name: "My amazing product",
type: "service"
type: "service",
attributes: ["color"]
}).then(function (product) {
// asynchronously called
const prodType: "service" | "good" = product.type;
Expand Down