[react-intl] FormattedMessage children prop#24670
[react-intl] FormattedMessage children prop#24670mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@osdiab Thank you for submitting this PR! 🔔 @bgrieder @cdroulers @gyzerok @tillwolff @LKay @bhouser @kristerkari @formatlos - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
|
I can have a look at wednesday |
|
@tillwolff I really don't why formattedMessage is a string, Is it a bug? I guess |
|
@brikou I dont really get your point, but when I check the react-intl code here: Then the defintion should be Would you agree to that? |
|
So the correct typings would be The following valid code throws currently an error in my application as <FormattedMessage id="guestInfos.email.placeholder">
{text => <Field type="email" name="email" placeholder={text} />}
</FormattedMessage> |
|
Ah my bad all, misread the source. I'll make a PR now. |
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
[ ] Increase the version number in the header if appropriate.[ ] If you are making substantial changes, consider adding atslint.jsoncontaining{ "extends": "dtslint/dt.json" }.Pretty sure the argument for
childrenshould be astring[], given whatformatMessagesreturns.