Skip to content

update types for heapdump #23891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mishelen wants to merge 1 commit into from
Closed

update types for heapdump #23891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/heapdump/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
// Definitions by: weekens <https://github.com/weekens>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped

export function writeSnapshot(dumpFileName: string, callback: (err?: Error) => void): void;
export function writeSnapshot(dumpFileName?: string, callback?: (err?: Error, filename?: string) => void): void;
Copy link
Copy Markdown

@ghost ghost Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the callback always returns the name of the file, this should be (err: Error | undefined, filename: string) => void.

Copy link
Copy Markdown
Author

@mishelen mishelen Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good rectification