Skip to content

Conversation

@jnizet
Copy link
Contributor

@jnizet jnizet commented Jan 13, 2018

the constants should be readonly, since the original source code has getters, but no setters for these constants (see https://github.com/moment/luxon/blob/master/src/datetime.js#L1715-L1850)

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

the constants should be readonly, since the original source code has getters, but no setters for these constants (see https://github.com/moment/luxon/blob/master/src/datetime.js#L1715-L1850)
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 13, 2018

@jnizet Thank you for submitting this PR!

🔔 @colbydehart @FourwingsY - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@typescript-bot
Copy link
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@weswigham weswigham merged commit 008daf5 into DefinitelyTyped:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants