Skip to content

Conversation

@wwestrop
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:
If changing an existing definition:

Other remarks:
I wasn't sure how mocha-tests.ts was being consumed. I've appeneded some dtslint tests to the end, they seem to work (and fail when they should too)

@dt-bot
Copy link
Member

dt-bot commented Dec 11, 2017

types/mocha/index.d.ts

to authors (@kazimanzurrashid @otiai10 @jt000 @enlight). Could you review this PR?
👍 or 👎?

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 12, 2017
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Dec 18, 2017
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@aozgaa aozgaa merged commit 78c4045 into DefinitelyTyped:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants