Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 27, 2017

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Nov 27, 2017

types/node/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Nov 27, 2017
@eps1lon
Copy link
Collaborator Author

eps1lon commented Nov 27, 2017

This did not pass travis checks. It threw an error but still returned with exit code 0.

npm run lint node
TypeError: ts.isVariableStatement is not a function

Edit:
Don't merge until microsoft/dtslint/issues/91 is resolved.

@eps1lon eps1lon closed this Dec 1, 2017
@eps1lon eps1lon reopened this Dec 1, 2017
@eps1lon
Copy link
Collaborator Author

eps1lon commented Dec 1, 2017

Closing and reopening this to trigger travis to rerun since microsoft/dtslint#91 was fixed.

@typescript-bot
Copy link
Contributor

This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Dec 2, 2017
@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Unmerged The author did not merge the PR when it was ready. labels Dec 5, 2017
@typescript-bot
Copy link
Contributor

@eps1lon Please address the merge conflict.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Dec 5, 2017

This landed via d251c64

@eps1lon eps1lon closed this Dec 5, 2017
@eps1lon eps1lon deleted the fix-tslint-disable branch July 29, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants