Skip to content

Conversation

@pine
Copy link
Contributor

@pine pine commented Oct 30, 2017

Hello. I've updated gulp-tslint types. Thank you.
https://github.com/panuhorsmalahti/gulp-tslint


  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/panuhorsmalahti/gulp-tslint
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot typescript-bot added the Unowned This PR touches a package that doesn't have any listed owners. label Oct 30, 2017
@RyanCavanaugh
Copy link
Member

This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections.

@RyanCavanaugh RyanCavanaugh added the Unmerged The author did not merge the PR when it was ready. label Nov 4, 2017
@DanielRosenwasser
Copy link
Member

@pine why is this necessary if there are already types for gulp-tslint?

@pine
Copy link
Contributor Author

pine commented Nov 8, 2017

Hello @DanielRosenwasser .

This is not new .d.ts file.
The existed types is too old. I've updated the existed types.

Thank you.

@pine
Copy link
Contributor Author

pine commented Nov 8, 2017

Hello @DanielRosenwasser. I'm sorry. I did't know that gulp-tslint has official types.
https://github.com/panuhorsmalahti/gulp-tslint/blob/master/index.d.ts

Thank you.

@pine pine closed this Nov 8, 2017
@pine pine deleted the feat/gulp-tslint-v8.x branch November 8, 2017 17:29
@ghost ghost mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready. Unowned This PR touches a package that doesn't have any listed owners.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants