jsonwebtoken - Typings for PR413#20321
jsonwebtoken - Typings for PR413#20321Richie765 wants to merge 4 commits intoDefinitelyTyped:masterfrom
Conversation
|
types/jsonwebtoken/index.d.ts to authors (@SomaticIT @danielheim). Could you review this PR? Checklist
|
|
This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections. |
types/jsonwebtoken/index.d.ts
Outdated
| (err: Error, encoded: string): void; | ||
| } | ||
|
|
||
| export interface SecretCallback { |
There was a problem hiding this comment.
Don't think this deserves its own type declaration. Can just do:
export type SecretFunc = (header: object, callback: (err: Error, secretOrPrivateKey: string | buffer) => void) => void;There was a problem hiding this comment.
That's a good one 👍. Will update it soon!
There was a problem hiding this comment.
Forgot to remove this? It's already been inlined into SecretFunc so should be OK to delete.
|
This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections. |
|
@Richie765 Please address the merge conflict. |
|
@Richie765 I'm not sure if you're still waiting on something. Do you still need this PR open? |
|
Closing stale PR for housekeeping reasons. If you would still like these changes to get merged, please open a new PR. Thank you! |
See PR auth0/node-jsonwebtoken#413
Please wait until that PR is merged.