[@types/node] EventEmitter union of http.Server and https.Server #71059
Unanswered
Cooldude2606
asked this question in
Issues with a @types package
Replies: 1 comment
-
|
Thanks for the discussion about "node", some useful links for everyone: Pinging the DT module owners: @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Our CI build pipeline broke because of a change in the last 48 hours. I beleive it was the merge of #69997 and release of
@types/node@22.8.5(the issue is not present with@types/node@22.8.4)The issue is specifically the use of
EventEmitter.offon the unionhttp.Server | https.Servera minimal example is below.Locally I am using
typescript@5.4.2andnode@20.5.1; our CI usedtypescript@5.6.3and bothnode@18.20.4andnode@20.18.0I do not see any difference in these types or why they would be incompatible with each other especially since there is no issue using the
onmethod. Through looking at the type files I observed a lack ofoffandremoveListnerdeclarations inhttp.d.tshttps.d.tsandnet.d.tswhich might be the cause, if these declarations are added then the error goes away; however, many other packages do not include these and do not have issues.I am not sure what would need to be investigated next and hope to gain some assistance here, until this is resolved I will lock the CI to version 22.8.4 because that version works.
Beta Was this translation helpful? Give feedback.
All reactions