[@types/node] Any reasons why OutgoingHttpHeaders is not typed? #66753
Replies: 2 comments 7 replies
-
|
Thanks for the discussion about "node", some useful links for everyone: Pinging the DT module owners: @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky. |
Beta Was this translation helpful? Give feedback.
-
|
In TS the type |
Beta Was this translation helpful? Give feedback.
-
|
@skwee357 I rechecked: the type |
Beta Was this translation helpful? Give feedback.
-
|
@Semigradsky While numbers for HTTP value is understandable, I'm not sure if it's worth to leave reply header non typed. Request headers are typed, and they can have arbitrary values as well, why can't we work on doing the same for reply headers? |
Beta Was this translation helpful? Give feedback.
-
|
@skwee357 ok, I was confused by what you have There is no sense in changing the |
Beta Was this translation helpful? Give feedback.
-
|
Added types in a similar manner to |
Beta Was this translation helpful? Give feedback.
-
|
@skwee357 any reason |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I wanted to add reply header types to fastify, and created a PR fastify/fastify#5046. However, I was pointed out by one of the contributors that header types actually come from
@types/node.Upon closer inspection, it seems like
OutgoingHttpHeaderdoes not have a concrete type (DefinitelyTyped/types/node/http.d.ts
Line 115 in 64f8bd1
number | string | string[].IncomingHttpHeaders, on the other hand, does have proper typing.Is there any reason behind it?
Beta Was this translation helpful? Give feedback.
All reactions