Finialize moving most important DB models to a common crate#1713
Merged
Finialize moving most important DB models to a common crate#1713
Conversation
3f4aae0 to
8b92676
Compare
t-aleksander
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to reorganize existing code in preparation for adding the VPN client session manager component, but also other components planned for the next release.
By putting most models into the
defguard_commoncrate it brings us really close to being able to finally split the core crate into separate components for API, gRPC server etc.The changes mostly come down to moving most important models (User, Device, WireguardNetwork etc) to
defguard_commonand removing foreign type implementations.This should force us into a better structure for our code and avoid making the compilation time and inter-component dependencies worse.