Skip to content

docs: update README.md#443

Merged
gcroci2 merged 6 commits intomainfrom
gcroci2-patch-1
Jun 8, 2023
Merged

docs: update README.md#443
gcroci2 merged 6 commits intomainfrom
gcroci2-patch-1

Conversation

@gcroci2
Copy link
Copy Markdown
Collaborator

@gcroci2 gcroci2 commented Jun 2, 2023

The current PyPi release does not work with the documentation we have, because the release is outdated. I'll do a new release very soon but in the meantime we need to add that to the readme

The current PyPi release does not work with the documentation we have, because the release is outdated. I'll do a new release very soon but in the meantime we need to add that to the readme
@gcroci2 gcroci2 requested a review from DaniBodor June 2, 2023 14:55
@DaniBodor
Copy link
Copy Markdown
Collaborator

what do you mean by it doesn't work?

@gcroci2
Copy link
Copy Markdown
Collaborator Author

gcroci2 commented Jun 5, 2023

what do you mean by it doesn't work?

The docs are updated with the code, but the release is old so if you pip install deeprankcore using the released version (1.0.0) and then try to follow the docs for using the package, you'll get errors and issues.

Copy link
Copy Markdown
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also remove reduce from install instructions already? Even though the other thing isn't ready to be announced yet, reduce is not useful and only gives bugs anyway and is the most tedious part of the install instructions.

@gcroci2
Copy link
Copy Markdown
Collaborator Author

gcroci2 commented Jun 7, 2023

Maybe also remove reduce from install instructions already? Even though the other thing isn't ready to be announced yet, reduce is not useful and only gives bugs anyway and is the most tedious part of the install instructions.

Done, I've also removed reduce from the CI, since we're not testing add_hydrogens it shouldn't break anything.

@gcroci2 gcroci2 requested a review from DaniBodor June 7, 2023 14:41
Copy link
Copy Markdown
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@gcroci2 gcroci2 merged commit a1fb024 into main Jun 8, 2023
@gcroci2 gcroci2 deleted the gcroci2-patch-1 branch June 8, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants