[codex] extend inline title editing across canvas nodes#226
Merged
DeadWaveWave merged 6 commits intoDeadWaveWave:mainfrom May 5, 2026
Merged
[codex] extend inline title editing across canvas nodes#226DeadWaveWave merged 6 commits intoDeadWaveWave:mainfrom
DeadWaveWave merged 6 commits intoDeadWaveWave:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
This PR extends the note-style inline title editing interaction across the remaining editable canvas nodes:
Terminal,Agent Terminal, andTask, while keepingDocumentunchanged.It also tightens the interaction model so only the title text hit area shows the I-beam cursor and enters edit mode. Header blank space remains available for selection and dragging, and editing blocks drag/select until the title input saves or cancels.
On top of the feature rollout, this PR fixes the long-title rendering and drag-hit-area regressions that surfaced during validation, and updates the E2E gesture helpers/tests so the new interaction stays covered.
🏗️ Large Change Spec (Required if "Large Change" is checked)
1. Context & Business Logic
Users should be able to treat node titles as editable text instead of separate rename controls. The expected interaction is consistent across note/task/terminal-style nodes: hover only on text, click text to edit,
Entersave,Esccancel, blur save, and blank header area still supports canvas drag/selection behavior.2. State Ownership & Invariants
3. Verification Plan & Regression Layer
Primary regression coverage is E2E because the risk is user-visible and depends on hit testing, focus/blur, drag behavior, and persistence across renderer boundaries.
Validation run:
pnpm line-check:stagedpnpm pre-commit✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.CLA.md).DEVELOPMENT.mdarchitectural boundaries.📸 Screenshots / Visual Evidence
UI interaction change. Screenshot/screen recording can be attached in the GitHub PR UI.