fix: make standalone asset build cross-platform#212
Merged
DeadWaveWave merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
Fixes the nightly/stable release pipeline regression introduced in #209 where the standalone server bundle step failed on Windows runners.
What changed:
CSC_IDENTITY_AUTO_DISCOVERY=false ...npm script with a Node-driven cross-platform wrapper.electron-builder --dir --publish neverbehavior used by standalone asset builds.pnpm.cmd+ env injection path so this regression does not silently return.🏗️ Large Change Spec (Required if "Large Change" is checked)
N/A. This PR is a localized CI/release script fix.
✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.CLA.md).DEVELOPMENT.mdarchitectural boundaries.Verification completed:
pnpm exec vitest run tests/unit/scripts/standalone-asset-build.spec.tspnpm line-check:stagedpnpm naming-check:stagedpnpm secret-check:stagedpnpm format-check:stagedpnpm test:stagedNot run:
pnpm pre-commit(full suite not necessary for this localized CI script fix)📸 Screenshots / Visual Evidence
N/A: no UI surface changed.