Skip to content

fix: make standalone asset build cross-platform#212

Merged
DeadWaveWave merged 1 commit intomainfrom
fix/nightly-windows-standalone-build
May 1, 2026
Merged

fix: make standalone asset build cross-platform#212
DeadWaveWave merged 1 commit intomainfrom
fix/nightly-windows-standalone-build

Conversation

@DeadWaveWave
Copy link
Copy Markdown
Owner

💡 Change Scope

  • Small Change: Fast feedback, localized UI/logic, low-risk.
  • Large Change: New feature, cross-boundary logic, runtime-risk (persistence, IPC, lifecycle, recovery).

📝 What Does This PR Do?

Fixes the nightly/stable release pipeline regression introduced in #209 where the standalone server bundle step failed on Windows runners.

What changed:

  • Replaces the POSIX-only CSC_IDENTITY_AUTO_DISCOVERY=false ... npm script with a Node-driven cross-platform wrapper.
  • Preserves the unsigned electron-builder --dir --publish never behavior used by standalone asset builds.
  • Adds a unit test that locks down the Windows pnpm.cmd + env injection path so this regression does not silently return.

🏗️ Large Change Spec (Required if "Large Change" is checked)

N/A. This PR is a localized CI/release script fix.


✅ Delivery & Compliance Checklist

  • My code passes the ultimate gatekeeper: pnpm pre-commit is completely green.
  • I have signed the CLA if required (see CLA.md).
  • I have included new tests to lock down the behavior (or explicitly stated why it's untestable).
  • I have strictly adhered to the DEVELOPMENT.md architectural boundaries.
  • I have attached a screenshot or screen recording (if this touches the UI).
  • I have updated the documentation accordingly (if adding a feature or changing a contract).

Verification completed:

  • pnpm exec vitest run tests/unit/scripts/standalone-asset-build.spec.ts
  • pnpm line-check:staged
  • pnpm naming-check:staged
  • pnpm secret-check:staged
  • pnpm format-check:staged
  • pnpm test:staged

Not run:

  • pnpm pre-commit (full suite not necessary for this localized CI script fix)

📸 Screenshots / Visual Evidence

N/A: no UI surface changed.

@DeadWaveWave DeadWaveWave merged commit 97857ac into main May 1, 2026
7 checks passed
@DeadWaveWave DeadWaveWave deleted the fix/nightly-windows-standalone-build branch May 1, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant