Skip to content

Simpleform 5.4 broke specs #199

@tagliala

Description

@tagliala

Steps to reproduce*

  1. Run specs

Expected behavior*

Specs pass

Actual behavior*

$ be rake test:ruby TESTOPTS="-n/test_input_override/"
Run options: -n/test_input_override/ --seed 18913

# Running:

F

Failure:
ClientSideValidations::SimpleForm::FormHelperTest#test_input_override [test/simple_form/cases/test_form_helpers.rb:108]:
Expected: <form accept-charset="UTF-8" action="/posts" class="simple_form new_post" data-client-side-validations="{&quot;html_settings&quot;:{&quot;type&quot;:&quot;SimpleForm::FormBuilder&quot;,&quot;error_class&quot;:&quot;error&quot;,&quot;error_tag&quot;:&quot;span&quot;,&quot;wrapper_error_class&quot;:&quot;field_with_errors&quot;,&quot;wrapper_tag&quot;:&quot;div&quot;,&quot;wrapper_class&quot;:&quot;input&quot;,&quot;wrapper&quot;:&quot;default&quot;},&quot;number_format&quot;:{&quot;separator&quot;:&quot;.&quot;,&quot;delimiter&quot;:&quot;,&quot;},&quot;validators&quot;:{}}" id="new_post" method="post" novalidate="novalidate"><input name="utf8" type="hidden" value="&#x2713;" autocomplete="off" /><div class="input string required post_cost"><label class="string required" for="post_cost"><abbr title="required">*</abbr> Cost</label><input aria-required="true" class="string required" id="post_cost" name="post[cost]" required="required" type="text" /></div></form>
Actual: <form class="simple_form new_post" id="new_post" action="/posts" accept-charset="UTF-8" novalidate="novalidate" data-client-side-validations="{&quot;html_settings&quot;:{&quot;type&quot;:&quot;SimpleForm::FormBuilder&quot;,&quot;error_class&quot;:&quot;error&quot;,&quot;error_tag&quot;:&quot;span&quot;,&quot;wrapper_error_class&quot;:&quot;field_with_errors&quot;,&quot;wrapper_tag&quot;:&quot;div&quot;,&quot;wrapper_class&quot;:&quot;input&quot;,&quot;wrapper&quot;:&quot;default&quot;},&quot;number_format&quot;:{&quot;separator&quot;:&quot;.&quot;,&quot;delimiter&quot;:&quot;,&quot;},&quot;validators&quot;:{}}" method="post"><input type="hidden" name="utf8" value="&#x2713;" autocomplete="off" /><div class="input string required post_cost"><label class="string required" for="post_cost"><abbr title="required">*</abbr> Cost</label><input class="string required" required="required" type="text" name="post[cost]" id="post_cost" /></div></form>

System configuration*

Rails version: n/a

Ruby version: n/a

Client Side Validations version: main

Client Side Validations Simple Form version: main

Bootstrap version (if used): n/a

Repository demostrating the issue

This

Bisect: HEAD is now at heartcombo/simple_form@c439da9 Remove aria-required for required fields in HTML5 (heartcombo/simple_form#1823)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions