Update libfmt use for support of C++20 and newer#24
Merged
DavidAce merged 1 commit intoDavidAce:masterfrom Mar 19, 2025
Merged
Conversation
|
this change seems to have broken support for compiling without |
Owner
|
Thanks for pointing this out! The issue is fixed in the latest commit. |
Contributor
Author
|
I guess it would be nice also to add one build without libfmt to GitHub actions (one build is probably sufficient, no need to duplicate all). We would have noticed problem earlier due to such build failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not compile when
Included patch fixes the problem