Skip to content

Add Attributes to OTLP Metrics Test#7039

Merged
mhlidd merged 4 commits into
mainfrom
mhlidd/add_attributes_to_otlp
May 29, 2026
Merged

Add Attributes to OTLP Metrics Test#7039
mhlidd merged 4 commits into
mainfrom
mhlidd/add_attributes_to_otlp

Conversation

@mhlidd

@mhlidd mhlidd commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

This PR adds Attributes to OTLP Metrics tests. It sets the framework for metric testing w/ Attributes and implements JVM Metric Attributes. The other languages are left empty so the test result remains the same as before, and language experts can add in the correct attributes.

This PR also adds validation for extra metrics from this Java PR, and enables the test for the correct Java version.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@mhlidd mhlidd requested review from a team as code owners May 28, 2026 21:08
@github-actions

github-actions Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
tests/test_otlp_runtime_metrics.py                                      @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 28, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd8b9d19f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/java.yml Outdated
tests/test_library_logs.py::Test_NoExceptions::test_dotnet: irrelevant (only for .NET)
tests/test_otlp_runtime_metrics.py::Test_OtlpRuntimeMetrics::test_dd_metrics_are_absent: bug (APMAPI-1952)
tests/test_otlp_runtime_metrics.py::Test_OtlpRuntimeMetrics::test_otel_metrics_are_present: missing_feature
tests/test_otlp_runtime_metrics.py::Test_OtlpRuntimeMetrics::test_otel_metrics_are_present_and_attributed: v1.63.0

@chatgpt-codex-connector chatgpt-codex-connector Bot May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Set the Java runtime metrics start delay before enabling

When this manifest makes the Java OTLP runtime-metrics test active, it runs under otlp_runtime_metrics, which enables runtime metrics with only a 20s library_interface_timeout but does not set DD_DOGSTATSD_START_DELAY=0; I checked the adjacent runtime_metrics_enabled scenario, and it explicitly adds that env var because the Java tracer otherwise waits 30s before emitting runtime metrics. With Java now activated here, the test can assert before any OTLP runtime metrics have been flushed, so the presence checks will fail or be flaky until the OTLP scenario gets the same Java startup-delay override.

Useful? React with 👍 / 👎.

@datadog-official

This comment has been minimized.

Sign in to view
@mhlidd mhlidd merged commit 03abb49 into main May 29, 2026
2022 checks passed
@mhlidd mhlidd deleted the mhlidd/add_attributes_to_otlp branch May 29, 2026 19:36
@mhlidd mhlidd mentioned this pull request May 29, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@link04 link04 link04 approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@claponcet claponcet Awaiting requested review from claponcet claponcet is a code owner automatically assigned from DataDog/asm-java

@anna-git anna-git Awaiting requested review from anna-git

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhlidd @link04