Skip to content

add test for network.client.ip tag#6707

Merged
smola merged 1 commit into
mainfrom
smola/network-client-ip
Apr 21, 2026
Merged

add test for network.client.ip tag#6707
smola merged 1 commit into
mainfrom
smola/network-client-ip

Conversation

@smola

@smola smola commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

To align network.client.ip behavior, adding a system test. Most tracers already implemented collection of network.client.ip correctly. There was some ambiguity as to when to collect it. With most tracers collecting it only for AppSec events.

The spec is now amended to ensure that network.client.ip is collected for all HTTP request when the activation conditions are met. These are the same as for http.client_ip: when DD_APPSEC_ENABLED=true or DD_TRACE_CLIENT_IP_ENABLED=true are set.

APPSEC-62223

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/envoy.yml                                                     @DataDog/system-tests-core
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/haproxy.yml                                                   @DataDog/system-tests-core
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/test_standard_tags.py                                             @DataDog/system-tests-core

@smola smola force-pushed the smola/network-client-ip branch 4 times, most recently from 678bc2d to 7615cdb Compare April 10, 2026 09:41
@datadog-official

datadog-official Bot commented Apr 10, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 194a058 | Docs | Datadog PR Page | Give us feedback!

@smola smola force-pushed the smola/network-client-ip branch from 7615cdb to c64707f Compare April 10, 2026 10:07
@smola smola marked this pull request as ready for review April 10, 2026 10:08
@smola smola requested review from a team as code owners April 10, 2026 10:08
@smola smola requested review from P403n1x87, avara1986, claponcet, jandro996 and ygree and removed request for a team April 10, 2026 10:08
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 10, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c64707fae2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/test_standard_tags.py
Comment on lines +210 to +212
@scenarios.go_proxies_default
@scenarios.default
class Test_StandardTagsNetworkClientIp:

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate network client IP tests by supported tracer versions

Adding this class enables it by default in DEFAULT and GO_PROXIES_DEFAULT for any library/version that lacks an explicit manifest rule, because unspecified tests are treated as enabled (see docs/edit/manifest.md). That creates a regression for older tracer versions that still do not emit http.client_ip/network.client.ip (the existing Test_StandardTagsClientIp is version-gated per language, e.g. in manifests/nodejs.yml and manifests/java.yml), so test_network_client_ip_with_attack can start failing in release-version runs. Please add class/method manifest gating for this new class with the same support floor as client-ip tagging.

Useful? React with 👍 / 👎.

Julio-Guerra
Julio-Guerra reviewed Apr 10, 2026
View reviewed changes
Comment thread tests/test_standard_tags.py
@smola smola force-pushed the smola/network-client-ip branch from c64707f to 04fab3f Compare April 10, 2026 11:54
nccatoni
nccatoni reviewed Apr 10, 2026
View reviewed changes

@nccatoni nccatoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @DataDog/system-tests-core but you should get an approval from someone familiar with the feature

simon-id
simon-id reviewed Apr 10, 2026
View reviewed changes
Comment thread manifests/nodejs.yml Outdated
@smola smola force-pushed the smola/network-client-ip branch from 04fab3f to 0fcf185 Compare April 10, 2026 13:17
@smola smola force-pushed the smola/network-client-ip branch from 0fcf185 to 4d60a43 Compare April 10, 2026 13:19
@smola smola requested review from Julio-Guerra and simon-id April 15, 2026 09:26
@smola smola force-pushed the smola/network-client-ip branch from 2ce879f to 8746b53 Compare April 20, 2026 12:56
@smola smola requested review from a team as code owners April 20, 2026 12:56
@smola smola force-pushed the smola/network-client-ip branch from 8746b53 to 194a058 Compare April 20, 2026 15:00
@smola smola merged commit 362079f into main Apr 21, 2026
872 of 893 checks passed
@smola smola deleted the smola/network-client-ip branch April 21, 2026 07:40
@smola smola mentioned this pull request Apr 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@Julio-Guerra Julio-Guerra Julio-Guerra approved these changes

@christophe-papazian christophe-papazian christophe-papazian approved these changes

@nccatoni nccatoni nccatoni approved these changes

@avara1986 avara1986 Awaiting requested review from avara1986 avara1986 is a code owner automatically assigned from DataDog/apm-python

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87 P403n1x87 is a code owner automatically assigned from DataDog/apm-python

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

@claponcet claponcet Awaiting requested review from claponcet claponcet is a code owner automatically assigned from DataDog/asm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@simon-id simon-id Awaiting requested review from simon-id

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smola @Julio-Guerra @simon-id @christophe-papazian @nccatoni