Add FFE exposure test EXP.5: treat missing targeting key as empty string#6040
Merged
Conversation
When targeting key is missing but evaluation produced result with doLog=true, the exposure events must be reported with subject.id = "". This test catches a bug in Go tracer where empty targeting keys incorrectly skip exposure events instead of reporting them with an empty subject ID.
Contributor
|
|
This was referenced Jan 16, 2026
The OpenFeature Java SDK rejects empty targeting keys due to an isEmpty check in MutableContext.setTargetingKey(). A fix is pending: open-feature/java-sdk#1291 The OpenFeature JS SDK similarly rejects empty targeting keys with a falsy check (!subjectKey). Until these upstream SDKs are fixed, the evaluation fails before the tracer can even generate exposure events.
Use manifest-based bug declarations instead of @bug decorators since the test framework requires manifest files for library-specific skip reasons. Java: OpenFeature SDK rejects empty targeting keys - fix pending open-feature/java-sdk#1807 Node.js: OpenFeature SDK rejects empty targeting keys with falsy check
0956e9b to
8b70bd8
Compare
typotter
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When targeting key is missing but evaluation produced result with doLog=true, the exposure events must be reported with subject.id = "".
This test catches a bug in Go tracer where empty targeting keys incorrectly skip exposure events instead of reporting them with an empty subject ID.
SDK Specification | EXP.5
Changes
Test_FFE_EXP_5_Missing_Targeting_Keytest class intests/ffe/test_exposures.pymanifests/java.yml: bug (FFL-1729)- OpenFeature Java SDK rejects empty targeting keysmanifests/nodejs.yml: bug (FFL-1730)- OpenFeature JS SDK rejects empty targeting keysWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present