Skip to content

[.NET] Enable remote config test for DD_TRACE_ENABLED #2319

Merged
lucaspimentel merged 1 commit intomainfrom
lpimentel/enable-dynamic-config-tracing-enabled
Apr 10, 2024
Merged

[.NET] Enable remote config test for DD_TRACE_ENABLED #2319
lucaspimentel merged 1 commit intomainfrom
lpimentel/enable-dynamic-config-tracing-enabled

Conversation

@lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Apr 9, 2024

Motivation

This feature was added in .NET tracing library v2.49.0.

(keyword: disablement)

Changes

Mark the test as "should pass."

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@lucaspimentel lucaspimentel added the dotnet Pull requests that update .NET code label Apr 9, 2024
@lucaspimentel lucaspimentel marked this pull request as ready for review April 9, 2024 21:16
@lucaspimentel lucaspimentel requested review from a team as code owners April 9, 2024 21:16
Copy link
Contributor

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@e-n-0 e-n-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@lucaspimentel lucaspimentel merged commit b4984ca into main Apr 10, 2024
@lucaspimentel lucaspimentel deleted the lpimentel/enable-dynamic-config-tracing-enabled branch April 10, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants