Skip to content

Updates tests for remote disablement of APM #2131

Merged
dianashevchenko merged 11 commits intomainfrom
shevchenko/apm-disablement-fix
Feb 16, 2024
Merged

Updates tests for remote disablement of APM #2131
dianashevchenko merged 11 commits intomainfrom
shevchenko/apm-disablement-fix

Conversation

@dianashevchenko
Copy link
Contributor

Motivation

The tests weren't run on an existing implementation, so they needed a small update to be consistent with RFC.
The changes were mentioned and discussed previously in office hours and slack channels.

Changes

  • changes telemetry config value from "false" to false
  • removes assertion for telemetry events when no configuration change occurs

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@dianashevchenko dianashevchenko requested review from a team as code owners February 8, 2024 15:14
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@cbeauchesne cbeauchesne marked this pull request as draft February 8, 2024 15:32
@dianashevchenko dianashevchenko marked this pull request as ready for review February 14, 2024 13:27
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From framework usage, AGTM.

Can you ask a review with somebody familiar with the tested feature to review the test itself ?

@emmettbutler emmettbutler self-requested a review February 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants