Updates tests for remote disablement of APM #2131
Merged
dianashevchenko merged 11 commits intomainfrom Feb 16, 2024
Merged
Conversation
Kyle-Verhoog
reviewed
Feb 9, 2024
cbeauchesne
approved these changes
Feb 14, 2024
Collaborator
cbeauchesne
left a comment
There was a problem hiding this comment.
From framework usage, AGTM.
Can you ask a review with somebody familiar with the tested feature to review the test itself ?
emmettbutler
requested changes
Feb 14, 2024
emmettbutler
approved these changes
Feb 16, 2024
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The tests weren't run on an existing implementation, so they needed a small update to be consistent with RFC.
The changes were mentioned and discussed previously in office hours and slack channels.
Changes
"false"tofalseWorkflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presentsbuild-XXX-imagelabel is present