ci: remove Codecov coverage upload#2094
Conversation
Co-authored-by: ManuelPalenzuelaDD <144776385+ManuelPalenzuelaDD@users.noreply.github.com>
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88c0243f5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: Upload coverage to Datadog | ||
| if: always() | ||
| continue-on-error: true |
There was a problem hiding this comment.
Preserve a failing signal for coverage uploads
With the Codecov step removed, the only remaining publisher in this workflow is the Datadog step below, and it is still marked continue-on-error: true. In the inspected coverage.yml workflow, that means pushes, PRs, and scheduled runs can now succeed after generating lcov.info even when the Datadog upload fails or the DATADOG_API_KEY secret is missing, so coverage can silently stop being reported. If Datadog is now the sole uploader, make this step required or add another required verification of the upload.
Useful? React with 👍 / 👎.
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 88c0243 | Docs | Datadog PR Page | Give us feedback! |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
What does this PR do?
Removes the Codecov coverage upload now that the migration to Datadog Code Coverage is complete.
CODECOV_TOKENusage) from thecoverageworkflow, leaving the Datadog coverage upload as the sole uploader..codecov.yml..codecov.ymlentry from.github/CODEOWNERS.Motivation
The Datadog Code Coverage migration (started in #1718) is done and verified, and a recent coverage workflow run failed on the Codecov GPG key. Codecov is no longer needed, and the team has no remaining attachment to it.
Additional Notes
The Datadog upload step is left unchanged. The
CODECOV_TOKENsecret can be removed separately at the repository settings level.How to test the change?
Trigger the Coverage workflow (PR/push/schedule) and confirm it runs without the Codecov step and that the Datadog coverage upload still succeeds.
PR by Bits - View session in Datadog
Comment @DataDog to request changes