Skip to content

Add license override for requests-unixsocket2#17769

Closed
steveny91 wants to merge 2 commits intomasterfrom
sy/update-license-unixsocket
Closed

Add license override for requests-unixsocket2#17769
steveny91 wants to merge 2 commits intomasterfrom
sy/update-license-unixsocket

Conversation

@steveny91
Copy link
Contributor

What does this PR do?

Add license override for requests-unixsocket2

@steveny91 steveny91 marked this pull request as ready for review June 7, 2024 03:02
@steveny91 steveny91 requested a review from a team as a code owner June 7, 2024 03:02
@codecov
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (f3533fe) to head (9f9c635).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
datadog_checks_dev 77.38% <ø> (+0.07%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jun 7, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

requests-kerberos = ['ISC']
# https://github.com/requests/requests-ntlm/blob/master/LICENSE
requests-ntlm = ['ISC']
# https://gitlab.com/thelabnyc/requests-unixsocket2/-/blob/master/LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a comment that explains that this is temporary and that we should remove it once the relevant issue or PR in the requests-unixsocket2 repo is complete?

@steveny91 steveny91 closed this Jun 7, 2024
@dd-devflow dd-devflow bot deleted the sy/update-license-unixsocket branch December 7, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants