Skip to content

chore(native): upgrade libdatadog to v35.0.0#18414

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
zach.montoya/update-libdatadog-otlp-fix
Jun 3, 2026
Merged

chore(native): upgrade libdatadog to v35.0.0#18414
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
zach.montoya/update-libdatadog-otlp-fix

Conversation

@zacharycmontoya

Copy link
Copy Markdown
Contributor

Description

Updates to libdatadog v35 to pull in a bug fix for the OTLP trace export pipeline.

Testing

Risks

Minimal. Only the libdatadog dependencies have been updated, not other crates

Additional Notes

@zacharycmontoya zacharycmontoya requested a review from a team as a code owner June 2, 2026 17:46
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64, 1]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). NotImplementedError: This version of CPython is not supported yet during import of ddtrace.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Job pod status retrieval failed due to context cancellation.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. NotImplementedError: This version of CPython is not supported yet

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 18859f7 | Docs | Datadog PR Page | Give us feedback!

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 2, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be54a53113

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/native/Cargo.toml
@zacharycmontoya

Copy link
Copy Markdown
Contributor Author

In theory I minimized the dependency changes but I didn't build locally so I didn't realize there were build issues after introducing the dependency bumps. I'll fix this up

…on. This was required starting in v35.0.0 but it will be removed so leaving this as a stub to be removed later is OK in order to adopt this version of libdatadog.
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codeowners resolved as

setup.py                                                                @DataDog/python-guild
src/native/Cargo.lock                                                   @DataDog/apm-core-python
src/native/Cargo.toml                                                   @DataDog/apm-core-python
src/native/py_string.rs                                                 @DataDog/apm-core-python

Comment thread src/native/py_string.rs
@zacharycmontoya zacharycmontoya requested a review from a team as a code owner June 2, 2026 19:57
@zacharycmontoya zacharycmontoya requested a review from avara1986 June 2, 2026 19:57
@pr-commenter

pr-commenter Bot commented Jun 2, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-02 20:24:59

Comparing candidate commit 18859f7 in PR branch zach.montoya/update-libdatadog-otlp-fix with baseline commit c3a5e37 in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 615 metrics, 10 unstable metrics.

scenario:iastaspects-strip_aspect

  • 🟥 execution_time [+64.271µs; +69.410µs] or [+20.101%; +21.708%]

scenario:iastaspects-translate_aspect

  • 🟥 execution_time [+56.270µs; +64.532µs] or [+10.925%; +12.529%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+99.776µs; +108.055µs] or [+23.611%; +25.570%]

scenario:span-start

  • 🟥 execution_time [+1.405ms; +1.569ms] or [+9.020%; +10.070%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+159.461ns; +191.949ns] or [+7.499%; +9.027%]

@zacharycmontoya

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 3, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-03 14:38:44 UTC ℹ️ Start processing command /merge


2026-06-03 14:38:49 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 51m (p90).


2026-06-03 15:40:47 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 9db6fc9 into main Jun 3, 2026
1234 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the zach.montoya/update-libdatadog-otlp-fix branch June 3, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants