feat: add dbm dynamic_service mode#18269
Conversation
|
BenchmarksBenchmark execution time: 2026-05-26 16:21:25 Comparing candidate commit f7bb6ed in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 615 metrics, 10 unstable metrics. scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
f7bb6ed to
bcf58a4
Compare
Codeowners resolved as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcf58a4070
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
emmettbutler
left a comment
There was a problem hiding this comment.
Release note looks good
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 1760991991687689213 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 466003051541639579 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
e92c957
into
main
Introduces a new DD_DBM_PROPAGATION_MODE=dynamic_service value that combines service mode behaviour with automatic SQL base hash injection, without requiring users to separately set DD_DBM_INJECT_SQL_BASEHASH=true.
(similar implem in dd-trace-java)
Setting dynamic_service is equivalent to:
DD_DBM_PROPAGATION_MODE=service
DD_DBM_INJECT_SQL_BASEHASH=true
Like service mode, dynamic_service injects service metadata tags (ddps, dddbs, ddh, dddb, dde, ddpv) and the base hash tag (ddsh) into comments. It does not inject traceparent (that remains exclusive to full mode).
Tested against this system-test
with
env TEST_LIBRARY=python ./run.sh DBM_DYNAMIC_SERVICE -F tests/integrations/test_dbm.py::Test_Dbm_DynamicService_Postgres tests/integrations/test_dbm.py::Test_Dbm_DynamicService_Postgres::test_dbm_dynamic_service