chore(profiling): proper setup for test needing ddup.config()#14788
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 241 ± 2 ms. The average import time from base is: 245 ± 4 ms. The import time difference between this PR and base is: -3.3 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate taegyunkim/prof-12678-ddup (4195d86) with baseline main (d033f37) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.175µs (SLO: <10.000µs 📉 -58.3%) vs baseline: +0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.078µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -1.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.817µs (SLO: <10.000µs 📉 -31.8%) vs baseline: 📈 +11.5% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.289µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.679µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +6.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 0.564µs (SLO: <10.000µs 📉 -94.4%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.698µs (SLO: <10.000µs 📉 -53.0%) vs baseline: -1.0% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.592µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.2% ✅ ospathsplitdrive_aspectTime: ✅ 3.654µs (SLO: <10.000µs 📉 -63.5%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.697µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.5% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ ospathsplitext_aspectTime: ✅ 4.525µs (SLO: <10.000µs 📉 -54.8%) vs baseline: +1.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.392µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.4% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.4% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.464ms (SLO: <22.300ms -8.2%) vs baseline: ~same Memory: ✅ 65.493MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.350ms (SLO: <1.450ms -6.9%) vs baseline: -0.3% Memory: ✅ 64.553MB (SLO: <67.000MB -3.7%) vs baseline: +4.9% ✅ iastTime: ✅ 20.407ms (SLO: <22.250ms -8.3%) vs baseline: -0.5% Memory: ✅ 65.443MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.258ms (SLO: <16.550ms -7.8%) vs baseline: -0.2% Memory: ✅ 53.730MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.599ms (SLO: <21.750ms -5.3%) vs baseline: +0.3% Memory: ✅ 65.506MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.202ms (SLO: <28.200ms -7.1%) vs baseline: -0.4% Memory: ✅ 67.527MB (SLO: <69.500MB -2.8%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.461ms (SLO: <21.750ms -5.9%) vs baseline: -0.3% Memory: ✅ 65.473MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.049ms (SLO: <23.500ms -6.2%) vs baseline: +0.3% Memory: ✅ 66.628MB (SLO: <67.500MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.364ms (SLO: <21.500ms -9.9%) vs baseline: ~same Memory: ✅ 65.595MB (SLO: <66.000MB 🟡 -0.6%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.661ms (SLO: <17.500ms -4.8%) vs baseline: +0.2% Memory: ✅ 65.374MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.511ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 71.372MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.404ms (SLO: <19.650ms -6.3%) vs baseline: -0.3% Memory: ✅ 65.431MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.779ms (SLO: <20.100ms -6.6%) vs baseline: -0.4% Memory: ✅ 65.345MB (SLO: <67.000MB -2.5%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.213ms (SLO: <21.500ms -6.0%) vs baseline: ~same Memory: ✅ 65.514MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.272ms (SLO: <22.000ms -7.9%) vs baseline: -0.5% Memory: ✅ 65.503MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.151ms (SLO: <19.850ms -8.6%) vs baseline: +0.3% Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.071ms (SLO: <19.400ms -6.8%) vs baseline: ~same Memory: ✅ 65.333MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.063ms (SLO: <19.450ms -7.1%) vs baseline: -0.2% Memory: ✅ 65.195MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +4.7% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.577ms (SLO: <4.750ms -3.6%) vs baseline: ~same Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.559ms (SLO: <6.750ms -2.8%) vs baseline: ~same Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.570ms (SLO: <4.750ms -3.8%) vs baseline: +0.1% Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 45.397MB (SLO: <47.000MB -3.4%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.871ms (SLO: <2.000ms -6.5%) vs baseline: +0.7% Memory: ✅ 42.290MB (SLO: <49.000MB 📉 -13.7%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: +0.4% Memory: ✅ 46.517MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.381ms (SLO: <3.650ms -7.4%) vs baseline: ~same Memory: ✅ 52.298MB (SLO: <53.500MB -2.2%) vs baseline: +5.1% ✅ tracerTime: ✅ 3.371ms (SLO: <3.650ms -7.6%) vs baseline: +0.1% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: -0.1% Memory: ✅ 58.260MB (SLO: <60.000MB -2.9%) vs baseline: +4.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.575ms (SLO: <47.150ms -3.3%) vs baseline: +1.4% Memory: ✅ 45.306MB (SLO: <47.000MB -3.6%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 321.868ms (SLO: <344.800ms -6.7%) vs baseline: +0.6% Memory: ✅ 552.874MB (SLO: <562.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 291.268ms (SLO: <314.000ms -7.2%) vs baseline: +0.3% Memory: ✅ 555.082MB (SLO: <563.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ get-contextTime: ✅ 84.058ms (SLO: <92.350ms -9.0%) vs baseline: +0.5% Memory: ✅ 40.249MB (SLO: <46.500MB 📉 -13.4%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 43.073ms (SLO: <44.500ms -3.2%) vs baseline: +0.6% Memory: ✅ 44.599MB (SLO: <47.500MB -6.1%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 61.538ms (SLO: <67.650ms -9.0%) vs baseline: ~same Memory: ✅ 40.643MB (SLO: <47.000MB 📉 -13.5%) vs baseline: +4.9% ✅ set-statusTime: ✅ 48.966ms (SLO: <50.400ms -2.8%) vs baseline: +0.5% Memory: ✅ 44.593MB (SLO: <47.000MB -5.1%) vs baseline: +4.8% ✅ startTime: ✅ 42.021ms (SLO: <43.450ms -3.3%) vs baseline: -0.5% Memory: ✅ 44.586MB (SLO: <47.000MB -5.1%) vs baseline: +4.7% ✅ start-finishTime: ✅ 84.982ms (SLO: <88.000ms -3.4%) vs baseline: +0.4% Memory: ✅ 34.642MB (SLO: <46.500MB 📉 -25.5%) vs baseline: +5.1% ✅ start-finish-telemetryTime: ✅ 86.227ms (SLO: <89.000ms -3.1%) vs baseline: +0.2% Memory: ✅ 34.642MB (SLO: <46.500MB 📉 -25.5%) vs baseline: +4.9% ✅ update-nameTime: ✅ 44.017ms (SLO: <45.150ms -2.5%) vs baseline: -0.4% Memory: ✅ 44.964MB (SLO: <47.000MB -4.3%) vs baseline: +4.9%
|
|
This seems to work as a temporary fix; although I thought you planned to call edit: It seems that |

https://datadoghq.atlassian.net/browse/PROF-12678
Description
test_wrapper()segfaults with following stack backtraceAs it indexes into empty
valuesvector. It is typically initialized by a call toddup.config(). Shuffle the test code intoTestThreadingLockCollectorclass to do so.Testing
Run
CMAKE_BUILD_PARALLEL_LEVEL=$(nproc) DD_FAST_BUILD=1 DD_TRACE_AGENT_URL=http://localhost:8126 riot -v run 9bb19fe --pass-env -- -s -vv -k test_wrapperRisks
Additional Notes
PROF-12678