Skip to content

chore: ignore useless conversion lint warning from pyo3 (#12450)#12453

Merged
brettlangdon merged 1 commit into
2.21from
backport-12450-to-2.21
Feb 21, 2025
Merged

chore: ignore useless conversion lint warning from pyo3 (#12450)#12453
brettlangdon merged 1 commit into
2.21from
backport-12450-to-2.21

Conversation

@brettlangdon

@brettlangdon brettlangdon commented Feb 20, 2025

Copy link
Copy Markdown
Member

Backport #12450 to 2.21 branch.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 20, 2025
@brettlangdon brettlangdon requested a review from a team as a code owner February 20, 2025 20:47
@brettlangdon brettlangdon requested a review from juanjux February 20, 2025 20:47
@github-actions

github-actions Bot commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

src/core/lib.rs                                                         @DataDog/apm-core-python

@brettlangdon brettlangdon enabled auto-merge (squash) February 20, 2025 20:47
@brettlangdon brettlangdon force-pushed the backport-12450-to-2.21 branch from 0edbd2a to 71a251c Compare February 20, 2025 20:48
@datadog-dd-trace-py-rkomorn

datadog-dd-trace-py-rkomorn Bot commented Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: backport-12450-to-2.21
Commit report: d95a789
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 1m 45.89s Total Time

@pr-commenter

pr-commenter Bot commented Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-02-21 15:54:09

Comparing candidate commit d95a789 in PR branch backport-12450-to-2.21 with baseline commit 6a4347f in branch 2.21.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 416 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathsplitext_aspect

  • 🟩 execution_time [-336.949ns; -284.607ns] or [-8.536%; -7.210%]

scenario:iast_aspects-split_aspect

  • 🟥 execution_time [+135.282ns; +172.136ns] or [+7.883%; +10.031%]

@brettlangdon brettlangdon force-pushed the backport-12450-to-2.21 branch from 71a251c to d95a789 Compare February 21, 2025 15:13
@brettlangdon brettlangdon merged commit 749133b into 2.21 Feb 21, 2025
@brettlangdon brettlangdon deleted the backport-12450-to-2.21 branch February 21, 2025 15:55
@erikayasuda erikayasuda mentioned this pull request Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@juanjux juanjux Awaiting requested review from juanjux juanjux is a code owner automatically assigned from DataDog/apm-core-python

+1 more reviewer

@sanchda sanchda sanchda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettlangdon @emmettbutler @sanchda @ajgajg1134