-
Notifications
You must be signed in to change notification settings - Fork 324
🍒 10344 - Add InstrumenterModule.Tracing for Aerospike #10373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a3e0c20)
PerfectSlayer
approved these changes
Jan 14, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084295
Total [baseline] (8.782 s) : 0, 8781930
Agent [candidate] (1.091 s) : 0, 1091107
Total [candidate] (8.752 s) : 0, 8752019
section iast
Agent [baseline] (1.23 s) : 0, 1229572
Total [baseline] (9.306 s) : 0, 9306173
Agent [candidate] (1.226 s) : 0, 1225836
Total [candidate] (9.339 s) : 0, 9338609
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (651.303 ms) : 0, 651303
BytebuddyAgent [candidate] (656.037 ms) : 0, 656037
GlobalTracer [baseline] (282.772 ms) : 0, 282772
GlobalTracer [candidate] (284.049 ms) : 0, 284049
AppSec [baseline] (32.698 ms) : 0, 32698
AppSec [candidate] (32.777 ms) : 0, 32777
Debugger [baseline] (67.467 ms) : 0, 67467
Debugger [candidate] (67.861 ms) : 0, 67861
Remote Config [baseline] (626.821 µs) : 0, 627
Remote Config [candidate] (620.434 µs) : 0, 620
Telemetry [baseline] (8.98 ms) : 0, 8980
Telemetry [candidate] (9.124 ms) : 0, 9124
Flare Poller [baseline] (3.786 ms) : 0, 3786
Flare Poller [candidate] (3.791 ms) : 0, 3791
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (796.256 ms) : 0, 796256
BytebuddyAgent [candidate] (793.083 ms) : 0, 793083
GlobalTracer [baseline] (257.154 ms) : 0, 257154
GlobalTracer [candidate] (256.55 ms) : 0, 256550
IAST [baseline] (27.34 ms) : 0, 27340
IAST [candidate] (27.24 ms) : 0, 27240
AppSec [baseline] (35.491 ms) : 0, 35491
AppSec [candidate] (33.461 ms) : 0, 33461
Debugger [baseline] (64.054 ms) : 0, 64054
Debugger [candidate] (66.214 ms) : 0, 66214
Remote Config [baseline] (574.893 µs) : 0, 575
Remote Config [candidate] (596.968 µs) : 0, 597
Telemetry [baseline] (8.465 ms) : 0, 8465
Telemetry [candidate] (8.471 ms) : 0, 8471
Flare Poller [baseline] (3.548 ms) : 0, 3548
Flare Poller [candidate] (3.532 ms) : 0, 3532
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084490
Total [baseline] (10.801 s) : 0, 10800573
Agent [candidate] (1.083 s) : 0, 1082652
Total [candidate] (10.846 s) : 0, 10845676
section appsec
Agent [baseline] (1.269 s) : 0, 1268608
Total [baseline] (11.059 s) : 0, 11059194
Agent [candidate] (1.276 s) : 0, 1276179
Total [candidate] (10.991 s) : 0, 10991223
section iast
Agent [baseline] (1.231 s) : 0, 1230701
Total [baseline] (11.308 s) : 0, 11308410
Agent [candidate] (1.242 s) : 0, 1242236
Total [candidate] (11.305 s) : 0, 11305099
section profiling
Agent [baseline] (1.205 s) : 0, 1205183
Total [baseline] (11.061 s) : 0, 11060860
Agent [candidate] (1.206 s) : 0, 1206141
Total [candidate] (11.003 s) : 0, 11003406
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (651.157 ms) : 0, 651157
BytebuddyAgent [candidate] (649.798 ms) : 0, 649798
GlobalTracer [baseline] (282.318 ms) : 0, 282318
GlobalTracer [candidate] (282.191 ms) : 0, 282191
AppSec [baseline] (32.714 ms) : 0, 32714
AppSec [candidate] (32.45 ms) : 0, 32450
Debugger [baseline] (68.083 ms) : 0, 68083
Debugger [candidate] (68.361 ms) : 0, 68361
Remote Config [baseline] (623.931 µs) : 0, 624
Remote Config [candidate] (600.461 µs) : 0, 600
Telemetry [baseline] (9.059 ms) : 0, 9059
Telemetry [candidate] (8.879 ms) : 0, 8879
Flare Poller [baseline] (3.806 ms) : 0, 3806
Flare Poller [candidate] (3.671 ms) : 0, 3671
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (692.4 ms) : 0, 692400
BytebuddyAgent [candidate] (697.061 ms) : 0, 697061
GlobalTracer [baseline] (258.825 ms) : 0, 258825
GlobalTracer [candidate] (261.895 ms) : 0, 261895
IAST [baseline] (24.611 ms) : 0, 24611
IAST [candidate] (25.147 ms) : 0, 25147
AppSec [baseline] (173.991 ms) : 0, 173991
AppSec [candidate] (174.723 ms) : 0, 174723
Debugger [baseline] (68.17 ms) : 0, 68170
Debugger [candidate] (66.699 ms) : 0, 66699
Remote Config [baseline] (730.198 µs) : 0, 730
Remote Config [candidate] (746.516 µs) : 0, 747
Telemetry [baseline] (9.482 ms) : 0, 9482
Telemetry [candidate] (9.387 ms) : 0, 9387
Flare Poller [baseline] (3.817 ms) : 0, 3817
Flare Poller [candidate] (3.724 ms) : 0, 3724
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (795.93 ms) : 0, 795930
BytebuddyAgent [candidate] (805.191 ms) : 0, 805191
GlobalTracer [baseline] (257.741 ms) : 0, 257741
GlobalTracer [candidate] (259.655 ms) : 0, 259655
IAST [baseline] (26.917 ms) : 0, 26917
IAST [candidate] (27.698 ms) : 0, 27698
AppSec [baseline] (34.519 ms) : 0, 34519
AppSec [candidate] (34.342 ms) : 0, 34342
Debugger [baseline] (66.101 ms) : 0, 66101
Debugger [candidate] (65.844 ms) : 0, 65844
Remote Config [baseline] (614.205 µs) : 0, 614
Remote Config [candidate] (612.403 µs) : 0, 612
Telemetry [baseline] (8.536 ms) : 0, 8536
Telemetry [candidate] (8.552 ms) : 0, 8552
Flare Poller [baseline] (3.61 ms) : 0, 3610
Flare Poller [candidate] (3.497 ms) : 0, 3497
section profiling
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (703.121 ms) : 0, 703121
BytebuddyAgent [candidate] (703.259 ms) : 0, 703259
GlobalTracer [baseline] (220.951 ms) : 0, 220951
GlobalTracer [candidate] (220.687 ms) : 0, 220687
AppSec [baseline] (32.257 ms) : 0, 32257
AppSec [candidate] (32.237 ms) : 0, 32237
Debugger [baseline] (67.625 ms) : 0, 67625
Debugger [candidate] (68.596 ms) : 0, 68596
Remote Config [baseline] (625.732 µs) : 0, 626
Remote Config [candidate] (624.021 µs) : 0, 624
Telemetry [baseline] (8.786 ms) : 0, 8786
Telemetry [candidate] (8.564 ms) : 0, 8564
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (3.633 ms) : 0, 3633
ProfilingAgent [baseline] (97.054 ms) : 0, 97054
ProfilingAgent [candidate] (97.433 ms) : 0, 97433
Profiling [baseline] (97.628 ms) : 0, 97628
Profiling [candidate] (98.005 ms) : 0, 98005
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (18.93 ms) : 18735, 19125
. : milestone, 18930,
appsec (19.199 ms) : 19004, 19394
. : milestone, 19199,
code_origins (17.946 ms) : 17766, 18127
. : milestone, 17946,
iast (17.595 ms) : 17421, 17769
. : milestone, 17595,
profiling (18.581 ms) : 18394, 18768
. : milestone, 18581,
tracing (17.88 ms) : 17705, 18056
. : milestone, 17880,
section candidate
no_agent (17.041 ms) : 16872, 17210
. : milestone, 17041,
appsec (18.466 ms) : 18279, 18653
. : milestone, 18466,
code_origins (17.691 ms) : 17513, 17868
. : milestone, 17691,
iast (17.682 ms) : 17505, 17859
. : milestone, 17682,
profiling (18.631 ms) : 18443, 18819
. : milestone, 18631,
tracing (17.701 ms) : 17527, 17875
. : milestone, 17701,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1174, 1197
. : milestone, 1186,
iast (3.169 ms) : 3127, 3210
. : milestone, 3169,
iast_FULL (5.436 ms) : 5382, 5489
. : milestone, 5436,
iast_GLOBAL (3.609 ms) : 3557, 3662
. : milestone, 3609,
profiling (1.947 ms) : 1930, 1965
. : milestone, 1947,
tracing (1.772 ms) : 1757, 1787
. : milestone, 1772,
section candidate
no_agent (1.185 ms) : 1174, 1197
. : milestone, 1185,
iast (3.255 ms) : 3210, 3300
. : milestone, 3255,
iast_FULL (5.841 ms) : 5782, 5900
. : milestone, 5841,
iast_GLOBAL (3.66 ms) : 3602, 3718
. : milestone, 3660,
profiling (1.967 ms) : 1950, 1983
. : milestone, 1967,
tracing (1.773 ms) : 1759, 1788
. : milestone, 1773,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
appsec (14.361 s) : 14361000, 14361000
. : milestone, 14361000,
iast (17.892 s) : 17892000, 17892000
. : milestone, 17892000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
tracing (14.703 s) : 14703000, 14703000
. : milestone, 14703000,
section candidate
no_agent (15.51 s) : 15510000, 15510000
. : milestone, 15510000,
appsec (14.541 s) : 14541000, 14541000
. : milestone, 14541000,
iast (18.168 s) : 18168000, 18168000
. : milestone, 18168000,
iast_GLOBAL (17.735 s) : 17735000, 17735000
. : milestone, 17735000,
profiling (15.207 s) : 15207000, 15207000
. : milestone, 15207000,
tracing (14.661 s) : 14661000, 14661000
. : milestone, 14661000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a17cb3f5a9, baseline=1.58.0~bd3f6f5c89
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.709 ms) : 3490, 3927
. : milestone, 3709,
iast (2.208 ms) : 2143, 2272
. : milestone, 2208,
iast_GLOBAL (2.255 ms) : 2190, 2321
. : milestone, 2255,
profiling (2.098 ms) : 2044, 2153
. : milestone, 2098,
tracing (2.047 ms) : 1996, 2098
. : milestone, 2047,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.713 ms) : 3494, 3933
. : milestone, 3713,
iast (2.208 ms) : 2144, 2272
. : milestone, 2208,
iast_GLOBAL (2.255 ms) : 2189, 2320
. : milestone, 2255,
profiling (2.061 ms) : 2008, 2113
. : milestone, 2061,
tracing (2.043 ms) : 1992, 2094
. : milestone, 2043,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10344 to release/v1.58.x
Aerospike instrumentation missed the qualifier .Tracing meaning that the instrumentation was not applying