Try fixing the test flakiness by using definitely not a Java fake PID (#11280)

jbachorik · web-flow · commit b0ccf93bd600 · 2026-05-05T12:39:51.000Z
Try fixing the test flakiness by using definitely not a Java fake PID

Merge branch 'master' into jb/temp_tests_2

Co-authored-by: jaroslav.bachorik &lt;jaroslav.bachorik@datadoghq.com&gt;
diff --git a/internal-api/src/test/java/datadog/trace/util/TempLocationManagerTest.java b/internal-api/src/test/java/datadog/trace/util/TempLocationManagerTest.java
@@ -103,7 +103,7 @@ void testCleanup(String subPath) throws Exception {
     assertNotNull(tempDir);
 
     // fake temp location
-    Path fakeTempDir = myDir.resolve(TempLocationManager.getBaseTempDirName()).resolve("pid_0000");
+    Path fakeTempDir = myDir.resolve(TempLocationManager.getBaseTempDirName()).resolve("pid_fake");
     Files.createDirectories(fakeTempDir);
     Path tmpFile = Files.createFile(fakeTempDir.resolve("test.txt"));
     tmpFile.toFile().deleteOnExit(); // make sure this is deleted at exit
@@ -138,7 +138,7 @@ void testConcurrentCleanup(String section) throws Exception {
     baseDir.toFile().deleteOnExit();
 
     Path fakeTempDir =
-        baseDir.resolve(TempLocationManager.getBaseTempDirName() + "/pid_1234/scratch");
+        baseDir.resolve(TempLocationManager.getBaseTempDirName() + "/pid_fake/scratch");
     Files.createDirectories(fakeTempDir);
     Path fakeTempFile = fakeTempDir.resolve("libxxx.so");
     Files.createFile(fakeTempFile);
@@ -291,7 +291,7 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs, boolean t
     baseDir.toFile().deleteOnExit();
     TempLocationManager instance = instance(baseDir, false, delayer, timeSource);
     Path mytempdir = instance.getTempDir();
-    Path otherTempdir = mytempdir.getParent().resolve("pid_0000");
+    Path otherTempdir = mytempdir.getParent().resolve("pid_fake");
     Files.createDirectories(otherTempdir);
     Files.createFile(mytempdir.resolve("dummy"));
     Files.createFile(otherTempdir.resolve("dummy"));
