Skip to content

Commit 73d1075

Browse files
authored
Mark 'check raw file injection' from LogInjectionSmokeTest as flaky on Oracle JDK8 (was previously marked as flaky on IBM JDK8) (#10560)
Mark 'check raw file injection' from LogInjectionSmokeTest as flaky on Oracle JDK8 (was previously marked as flaky on IBM JDK8) This is potentially related to RC product change event flakiness on Oracle JDK8, which was observed in a different smoke test: https://github.com/DataDog/dd-trace-java/blob/v1.59.0/dd-smoke-tests/dynamic-config/src/test/groovy/datadog/smoketest/AppSecActivationSmokeTest.groovy#L29 The 'check raw file injection' test also uses RC to toggle log-levels, and if this flakes then test assumptions wouldn't be met. Co-authored-by: stuart.mcculloch <stuart.mcculloch@datadoghq.com>
1 parent 26f8c70 commit 73d1075

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

dd-smoke-tests/log-injection/src/test/groovy/datadog/smoketest/LogInjectionSmokeTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ abstract class LogInjectionSmokeTest extends AbstractSmokeTest {
362362
return unmangled.split(" ")[1..2]
363363
}
364364

365-
@Flaky(condition = () -> JavaVirtualMachine.isIbm8())
365+
@Flaky(condition = () -> JavaVirtualMachine.isIbm8() || JavaVirtualMachine.isOracleJDK8())
366366
def "check raw file injection"() {
367367
when:
368368
def count = waitForTraceCount(2)

0 commit comments

Comments
 (0)