fix(appsec): inject CachedMethods helper class in Tomcat ParsePartsInstrumentation

jandro996 · jandro996 · commit 64dd1f56af13 · 2026-04-29T16:59:15.000+02:00
ByteBuddy only injects classes explicitly listed in helperClassNames(); nested
inner classes are not auto-discovered. Without this entry, the first addPart()
call triggers NoClassDefFoundError on CachedMethods, which is swallowed by the
broad catch in addPart(), silently dropping all filenames and file contents.
diff --git a/dd-java-agent/instrumentation/tomcat/tomcat-appsec/tomcat-appsec-7.0/src/main/java/datadog/trace/instrumentation/tomcat7/ParsePartsInstrumentation.java b/dd-java-agent/instrumentation/tomcat/tomcat-appsec/tomcat-appsec-7.0/src/main/java/datadog/trace/instrumentation/tomcat7/ParsePartsInstrumentation.java
@@ -59,6 +59,7 @@ public String[] helperClassNames() {
       "datadog.trace.instrumentation.tomcat7.ParameterCollector",
       "datadog.trace.instrumentation.tomcat7.ParameterCollector$ParameterCollectorNoop",
       "datadog.trace.instrumentation.tomcat7.ParameterCollector$ParameterCollectorImpl",
+      "datadog.trace.instrumentation.tomcat7.ParameterCollector$ParameterCollectorImpl$CachedMethods",
     };
   }
 

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@ public String[] helperClassNames() {`
`59`	`59`	`"datadog.trace.instrumentation.tomcat7.ParameterCollector",`
`60`	`60`	`"datadog.trace.instrumentation.tomcat7.ParameterCollector$ParameterCollectorNoop",`
`61`	`61`	`"datadog.trace.instrumentation.tomcat7.ParameterCollector$ParameterCollectorImpl",`
	`62`	`+ "datadog.trace.instrumentation.tomcat7.ParameterCollector$ParameterCollectorImpl$CachedMethods",`
`62`	`63`	`};`
`63`	`64`	`}`
`64`	`65`