feat: add service source on 10 integrations by raphaelgavache · Pull Request #4540 · DataDog/dd-trace-go

raphaelgavache · 2026-03-14T21:14:32Z

What does this PR do?

This PR is a follow-up from , completing 10 more integrations and adding missing integration tests for 5 of them.
Last remaining integration net/http due to its API will be covered alone.

Integration with no default, just WithService option

pubsub

Dynamic defaults (aws.{AWS_SERVICE})

aws_sdk_v1
aws_sdk_v2

Missing V1 support - not covered in naming test harness! For this PR verifying service source directly in the contrib

gorm
dns

Ones with no integration test <- completed with harness

pgx
bun
reuidis
valkey
fasthttp

Working integrations on system-test (see default service, contrib and @_dd.svc_src value

Motivation

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running make lint locally.
New code doesn't break existing tests. You can check this by running make test locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
All generated files are up to date. You can check this by running make generate locally.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

codecov · 2026-03-14T21:18:14Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.55%. Comparing base (215fa63) to head (379ea03).

Files with missing lines	Patch %	Lines
contrib/cloud.google.com/go/pubsubtrace/config.go	0.00%	2 Missing ⚠️
contrib/cloud.google.com/go/pubsubtrace/tracing.go	0.00%	2 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
contrib/cloud.google.com/go/pubsubtrace/config.go	`0.00% <0.00%> (ø)`
contrib/cloud.google.com/go/pubsubtrace/tracing.go	`0.00% <0.00%> (ø)`

... and 263 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

datadog-official · 2026-03-14T21:18:45Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 59.30% (-0.02%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: ab42e80 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

pr-commenter · 2026-03-14T21:45:39Z

Benchmarks

Benchmark execution time: 2026-03-15 03:00:25

Comparing candidate commit ab42e80 in PR branch raphael/last_easy with baseline commit 215fa63 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 156 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

rarguelloF

LGTM, just a comment on the aws ones

rarguelloF · 2026-03-16T10:03:19Z

+		instr.ServiceName(
+			instrumentation.ComponentDefault,
+			instrumentation.OperationContext{
+				ext.AWSService: awsService(req),
+			},
+		),


do we wanna signal this as a special case? I think this is the same as the driver name in database/sql, where the service name is being crafted / inferred from the request to the specific aws service (in sql there's something similar as this but with the driver name).

while it's a special case in the servic value (not a constant) it's not using any customer input, so there's no option to set. We already treat this as AWS integration case in the backend and remap it to the base service

rarguelloF · 2026-03-16T10:03:32Z

+		instr.ServiceName(instrumentation.ComponentDefault, instrumentation.OperationContext{
+			ext.AWSService: awsService,
+		}),
+		string(instrumentation.PackageAWSSDKGoV2),


(same here)

rarguelloF

LGTM

github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 14, 2026

raphaelgavache changed the title ~~Raphael/last easy~~ feat: add service source on 10 integrations Mar 14, 2026

raphaelgavache added the changelog/no-changelog label Mar 14, 2026

raphaelgavache force-pushed the raphael/last_easy branch from ba87a72 to 379ea03 Compare March 15, 2026 02:38

add easy batch

ab42e80

raphaelgavache force-pushed the raphael/last_easy branch from 379ea03 to ab42e80 Compare March 15, 2026 02:43

raphaelgavache added the AI Assisted AI/LLM assistance used in this PR (partially or fully) label Mar 15, 2026

raphaelgavache marked this pull request as ready for review March 16, 2026 02:32

raphaelgavache requested review from a team as code owners March 16, 2026 02:32

rarguelloF reviewed Mar 16, 2026

View reviewed changes

rarguelloF self-requested a review March 16, 2026 13:40

rarguelloF approved these changes Mar 16, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Mar 16, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 9f58198 into main Mar 16, 2026
126 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Mar 16, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the raphael/last_easy branch March 16, 2026 14:36

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Mar 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add service source on 10 integrations#4540

feat: add service source on 10 integrations#4540
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
raphael/last_easy

raphaelgavache commented Mar 14, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Mar 14, 2026 •

edited

Loading

Uh oh!

datadog-official Bot commented Mar 14, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Mar 14, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Uh oh!

rarguelloF left a comment

Uh oh!

rarguelloF Mar 16, 2026

Uh oh!

raphaelgavache Mar 16, 2026

Uh oh!

rarguelloF Mar 16, 2026

Uh oh!

rarguelloF left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

raphaelgavache commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Reviewer's Checklist

Uh oh!

codecov Bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

datadog-official Bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

Uh oh!

rarguelloF left a comment

Choose a reason for hiding this comment

Uh oh!

rarguelloF Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

raphaelgavache Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

rarguelloF Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

rarguelloF left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

raphaelgavache commented Mar 14, 2026 •

edited

Loading

codecov Bot commented Mar 14, 2026 •

edited

Loading

datadog-official Bot commented Mar 14, 2026 •

edited

Loading

pr-commenter Bot commented Mar 14, 2026 •

edited

Loading