Add some documentation on running system-tests#8298
Merged
Conversation
link04
reviewed
Mar 12, 2026
|
|
||
| 1. Add `docker_image_artifacts` label to your dd-trace-dotnet PR, this builds and pushes the Docker image | ||
| 2. In your system-tests PR *title*, include `[dotnet@your-branch-name]`, this makes system-tests CI to pull that Docker image | ||
|
|
Contributor
There was a problem hiding this comment.
Something I learned this week that we can add like this:
- The PR's (dev) tests will run against the image created, whereas (prod) runs against
masterwithout your changes.
link04
approved these changes
Mar 12, 2026
BenchmarksBenchmark execution time: 2026-03-16 15:46:19 Comparing candidate commit f7019c2 in PR branch Found 7 performance improvements and 4 performance regressions! Performance is the same for 166 metrics, 15 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
|
NachoEchevarria
approved these changes
Mar 13, 2026
39a4dbc to
f7019c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This adds a brief document on how to test PR changes in/against system-tests
Reason for change
Feedback on onboarding into the repository where it wasn't obvious how to run system-tests (it isn't great)
Implementation details
Searched for
system-tests.gitinultimate-pipeline.yamland outlined changing the branchLooked at the
docker_image_artifactslabel (introduced in #7337) and documented thatTest coverage
None!
Other details
I haven't really done this much so it may be wrong.
We have some documentation on running locally but last time I did that (~6 mos ago) it didn't work 😭