Skip to content

Rename telemetry GetData methods to GetIncrementalData#8269

Merged
andrewlock merged 1 commit into
masterfrom
andrew/telemetry/rename-methods
Mar 12, 2026
Merged

Rename telemetry GetData methods to GetIncrementalData#8269
andrewlock merged 1 commit into
masterfrom
andrew/telemetry/rename-methods

Conversation

@andrewlock

@andrewlock andrewlock commented Mar 4, 2026

Copy link
Copy Markdown
Member

Summary of changes

Renames GetData to GetIncrementalData to differentiate from GetFullData()

Reason for change

In #8227 it was flagged that GetData() and GetFullData() are easy to confuse. Renaming GetData to GetIncrementalData should solve it.

Implementation details

Deterministic rename (thank you IDEs, take that AI)

Test coverage

All covered by existing

@andrewlock andrewlock requested a review from a team as a code owner March 4, 2026 13:35
@andrewlock andrewlock mentioned this pull request Mar 4, 2026
Merged
@pr-commenter

pr-commenter Bot commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-04 16:29:15

Comparing candidate commit daa164d in PR branch andrew/telemetry/rename-methods with baseline commit f2220c0 in branch master.

Found 8 performance improvements and 6 performance regressions! Performance is the same for 171 metrics, 7 unstable metrics.

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-20.764ms; -15.085ms] or [-9.734%; -7.071%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-19.230ms; -14.861ms] or [-8.832%; -6.826%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-59.363µs; -31.214µs] or [-15.895%; -8.358%]
  • 🟩 throughput [+235.540op/s; +427.647op/s] or [+8.651%; +15.706%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+101.538ms; +102.876ms] or [+107.271%; +108.684%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+61.192ms; +66.810ms] or [+36.589%; +39.948%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+57.623ms; +63.081ms] or [+36.623%; +40.092%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • 🟩 execution_time [-436.049µs; -425.031µs] or [-13.788%; -13.440%]
  • 🟩 throughput [+49.261op/s; +50.402op/s] or [+15.578%; +15.939%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟥 execution_time [+57.000µs; +61.867µs] or [+5.595%; +6.073%]
  • 🟥 throughput [-56.245op/s; -51.948op/s] or [-5.730%; -5.292%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+31.544ms; +33.261ms] or [+33.297%; +35.109%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 execution_time [-14.129ms; -13.354ms] or [-6.622%; -6.258%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 execution_time [-17.534ms; -12.815ms] or [-8.165%; -5.968%]

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Mar 4, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8269) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration69.40 ± (69.44 - 69.71) ms69.24 ± (69.30 - 69.58) ms-0.2%✅
.NET Framework 4.8 - Bailout
duration73.32 ± (73.24 - 73.56) ms73.36 ± (73.19 - 73.45) ms+0.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1036.58 ± (1038.12 - 1043.15) ms1041.68 ± (1041.62 - 1047.49) ms+0.5%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms21.91 ± (21.88 - 21.94) ms22.09 ± (22.04 - 22.13) ms+0.8%✅⬆️
process.time_to_main_ms79.95 ± (79.79 - 80.11) ms80.24 ± (80.06 - 80.42) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.93) MB10.93 ± (10.93 - 10.94) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.73 ± (21.70 - 21.75) ms21.84 ± (21.81 - 21.88) ms+0.5%✅⬆️
process.time_to_main_ms80.99 ± (80.86 - 81.12) ms81.24 ± (81.12 - 81.37) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.97 ± (10.96 - 10.97) MB+0.2%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms256.71 ± (254.10 - 259.31) ms256.52 ± (254.47 - 258.56) ms-0.1%✅
process.time_to_main_ms470.47 ± (469.92 - 471.01) ms471.09 ± (470.63 - 471.55) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.65 ± (47.63 - 47.67) MB47.79 ± (47.77 - 47.81) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.9%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms20.70 ± (20.67 - 20.72) ms20.74 ± (20.71 - 20.77) ms+0.2%✅⬆️
process.time_to_main_ms69.40 ± (69.26 - 69.53) ms69.92 ± (69.79 - 70.06) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.64 ± (10.63 - 10.64) MB10.66 ± (10.66 - 10.67) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.61 ± (20.58 - 20.63) ms20.53 ± (20.50 - 20.56) ms-0.4%✅
process.time_to_main_ms69.96 ± (69.85 - 70.06) ms70.47 ± (70.37 - 70.56) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.73 ± (10.73 - 10.74) MB10.77 ± (10.77 - 10.78) MB+0.4%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms253.59 ± (252.41 - 254.76) ms252.20 ± (251.18 - 253.23) ms-0.5%✅
process.time_to_main_ms449.46 ± (449.07 - 449.84) ms451.46 ± (450.99 - 451.93) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.40 ± (48.37 - 48.44) MB48.55 ± (48.52 - 48.58) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms18.87 ± (18.85 - 18.90) ms18.89 ± (18.86 - 18.92) ms+0.1%✅⬆️
process.time_to_main_ms68.75 ± (68.62 - 68.89) ms68.57 ± (68.44 - 68.70) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.68 - 7.69) MB7.70 ± (7.69 - 7.70) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.99 ± (18.97 - 19.02) ms19.00 ± (18.97 - 19.03) ms+0.1%✅⬆️
process.time_to_main_ms69.95 ± (69.83 - 70.07) ms70.32 ± (70.17 - 70.46) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.75 ± (7.74 - 7.76) MB7.75 ± (7.74 - 7.76) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms179.64 ± (178.73 - 180.55) ms180.07 ± (179.27 - 180.88) ms+0.2%✅⬆️
process.time_to_main_ms429.14 ± (428.56 - 429.71) ms433.74 ± (433.11 - 434.37) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed35.90 ± (35.87 - 35.92) MB36.04 ± (36.01 - 36.07) MB+0.4%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.5%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.30 ± (193.20 - 193.92) ms195.17 ± (194.91 - 195.68) ms+1.0%✅⬆️
.NET Framework 4.8 - Bailout
duration198.20 ± (197.93 - 198.62) ms197.46 ± (197.37 - 197.78) ms-0.4%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1144.17 ± (1147.23 - 1155.92) ms1152.36 ± (1154.81 - 1163.53) ms+0.7%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.65 ± (187.34 - 187.96) ms188.97 ± (188.50 - 189.43) ms+0.7%✅⬆️
process.time_to_main_ms81.20 ± (81.01 - 81.40) ms82.27 ± (82.02 - 82.53) ms+1.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.21 ± (16.18 - 16.23) MB16.14 ± (16.11 - 16.17) MB-0.4%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.8%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.07 ± (186.75 - 187.40) ms187.86 ± (187.50 - 188.23) ms+0.4%✅⬆️
process.time_to_main_ms82.25 ± (82.11 - 82.39) ms83.35 ± (83.17 - 83.52) ms+1.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.31 ± (16.28 - 16.34) MB16.22 ± (16.19 - 16.25) MB-0.5%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (20 - 21)-0.7%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms439.23 ± (437.06 - 441.40) ms440.58 ± (438.25 - 442.91) ms+0.3%✅⬆️
process.time_to_main_ms476.76 ± (476.11 - 477.40) ms477.70 ± (477.01 - 478.39) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed57.98 ± (57.86 - 58.09) MB57.87 ± (57.75 - 57.99) MB-0.2%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms192.50 ± (192.10 - 192.89) ms191.92 ± (191.56 - 192.28) ms-0.3%✅
process.time_to_main_ms70.89 ± (70.67 - 71.11) ms70.85 ± (70.66 - 71.04) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.22 ± (16.12 - 16.33) MB16.34 ± (16.25 - 16.43) MB+0.7%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (18 - 19)-1.7%✅
.NET 6 - Bailout
process.internal_duration_ms191.87 ± (191.45 - 192.28) ms191.43 ± (191.03 - 191.84) ms-0.2%✅
process.time_to_main_ms71.82 ± (71.68 - 71.97) ms72.00 ± (71.84 - 72.17) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.26 ± (16.14 - 16.38) MB16.26 ± (16.13 - 16.39) MB+0.0%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)19 ± (19 - 19)-2.1%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms452.92 ± (451.24 - 454.60) ms454.65 ± (453.06 - 456.24) ms+0.4%✅⬆️
process.time_to_main_ms450.62 ± (450.06 - 451.18) ms455.95 ± (455.28 - 456.61) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.00 ± (57.89 - 58.12) MB57.87 ± (57.77 - 57.98) MB-0.2%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms190.28 ± (189.93 - 190.63) ms191.30 ± (190.91 - 191.69) ms+0.5%✅⬆️
process.time_to_main_ms69.97 ± (69.74 - 70.20) ms70.81 ± (70.62 - 70.99) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.75 ± (11.71 - 11.78) MB11.75 ± (11.73 - 11.77) MB+0.0%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.2%✅
.NET 8 - Bailout
process.internal_duration_ms189.86 ± (189.53 - 190.18) ms191.27 ± (190.84 - 191.69) ms+0.7%✅⬆️
process.time_to_main_ms71.25 ± (71.10 - 71.40) ms72.00 ± (71.81 - 72.18) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.79 ± (11.76 - 11.82) MB11.75 ± (11.72 - 11.78) MB-0.3%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms366.35 ± (365.02 - 367.67) ms367.54 ± (366.31 - 368.76) ms+0.3%✅⬆️
process.time_to_main_ms435.48 ± (434.77 - 436.19) ms439.69 ± (438.71 - 440.66) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.74 ± (47.71 - 47.77) MB47.76 ± (47.72 - 47.80) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.8%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (69ms)  : 67, 72
    master - mean (70ms)  : 68, 71

    section Bailout
    This PR (8269) - mean (73ms)  : 72, 75
    master - mean (73ms)  : 72, 75

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (1,045ms)  : 1001, 1088
    master - mean (1,041ms)  : 1005, 1076
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (108ms)  : 106, 111
    master - mean (108ms)  : 105, 110

    section Bailout
    This PR (8269) - mean (109ms)  : 107, 111
    master - mean (108ms)  : 107, 110

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (760ms)  : 723, 796
    master - mean (754ms)  : 708, 801
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (96ms)  : 93, 99
    master - mean (95ms)  : 92, 98

    section Bailout
    This PR (8269) - mean (96ms)  : 95, 98
    master - mean (96ms)  : 94, 97

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (736ms)  : 695, 777
    master - mean (736ms)  : 707, 764
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (94ms)  : 91, 97
    master - mean (94ms)  : 92, 97

    section Bailout
    This PR (8269) - mean (96ms)  : 94, 98
    master - mean (96ms)  : 93, 98

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (645ms)  : 624, 667
    master - mean (637ms)  : 623, 650
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (195ms)  : 192, 199
    master - mean (194ms)  : 190, 197

    section Bailout
    This PR (8269) - mean (198ms)  : 196, 199
    master - mean (198ms)  : 195, 202

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (1,159ms)  : 1096, 1223
    master - mean (1,152ms)  : 1087, 1216
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (280ms)  : 273, 287
    master - mean (278ms)  : 272, 283

    section Bailout
    This PR (8269) - mean (280ms)  : 275, 285
    master - mean (278ms)  : 274, 282

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (947ms)  : 898, 996
    master - mean (946ms)  : 901, 991
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (271ms)  : 266, 276
    master - mean (272ms)  : 266, 277

    section Bailout
    This PR (8269) - mean (272ms)  : 267, 277
    master - mean (272ms)  : 267, 277

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (942ms)  : 909, 975
    master - mean (933ms)  : 907, 959
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8269) - mean (272ms)  : 265, 278
    master - mean (270ms)  : 264, 276

    section Bailout
    This PR (8269) - mean (273ms)  : 266, 280
    master - mean (271ms)  : 267, 275

    section CallTarget+Inlining+NGEN
    This PR (8269) - mean (841ms)  : 820, 862
    master - mean (833ms)  : 813, 854
Loading

@andrewlock andrewlock force-pushed the andrew/telemetry/rename-methods branch from f61cc7e to daa164d Compare March 4, 2026 15:47
@andrewlock andrewlock merged commit 6c1f5da into master Mar 12, 2026
139 checks passed
@andrewlock andrewlock deleted the andrew/telemetry/rename-methods branch March 12, 2026 10:37
@github-actions github-actions Bot added this to the vNext-v3 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

area:telemetry type:refactor

Projects

None yet

Milestone

3.40.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @bouwkast @NachoEchevarria